Skip to content

Don't report SC2218 when another definition's order is unknown #3520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Eljees wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

Don't report SC2218 when another definition's order is unknown #3520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/ShellCheck/Analytics.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3901,6 +3901,8 @@ prop_checkUseBeforeDefinition3 = verifyNotTree checkUseBeforeDefinition "if ! my
prop_checkUseBeforeDefinition4 = verifyNotTree checkUseBeforeDefinition "mycmd || mycmd() { f; }"
prop_checkUseBeforeDefinition5 = verifyTree checkUseBeforeDefinition "false || mycmd; mycmd() { f; }"
prop_checkUseBeforeDefinition6 = verifyNotTree checkUseBeforeDefinition "f() { one; }; f; f() { two; }; f"
prop_checkUseBeforeDefinition7 = verifyNotTree checkUseBeforeDefinition "setup() { f() { true; }; }; f; f() { true; }"
prop_checkUseBeforeDefinition8 = verifyNotTree checkUseBeforeDefinition "#!/usr/bin/env bats\nsetup() { f() { true; }; }\n@test \"a\" {\n f\n}\n@test \"b\" {\n f() { true; }\n}"
checkUseBeforeDefinition :: Parameters -> Token -> [TokenComment]
checkUseBeforeDefinition params t = fromMaybe [] $ do
cfga <- cfgAnalysis params
Expand All @@ -3920,7 +3922,10 @@ checkUseBeforeDefinition params t = fromMaybe [] $ do
name <- getLiteralString cmd
invocations <- Map.lookup name funcs
-- Is the function definitely being defined later?
guard $ any (\c -> CF.doesPostDominate cfga c id) invocations
-- Every definition has to be later: one whose order we can't
-- determine, such as in a function nothing visibly invokes,
-- may already have run.
guard $ all (\c -> CF.doesPostDominate cfga c id) invocations
-- Was one already defined, so it's actually a re-definition?
guard . not $ any (\c -> CF.doesPostDominate cfga id c) invocations
return $ err id 2218 "This function is only defined later. Move the definition up."
Expand Down
Loading