Skip to content

SC1129

Jump to bottom Edit New page
Joachim Ansorg edited this page Nov 12, 2021 · 2 revisions

You need a space before the !.

Problematic code:

while! [ -f file ]
do sleep 1; done

Correct code:

while ! [ -f file ]
do sleep 1; done

Rationale:

ShellCheck found a keyword immediately followed by a !. There needs to be a space between them.

Exceptions:

None

cmd <<< $var # Requires quoting on Bash 3 (but not 4+) : ${var=default} # Should be quoted to avoid DoS when var='/////'debug="" $1 == "--trace-commands" && debug="yes" bash ${debug:+"-x"} scriptdebug="" $1 == "--trace-commands" && debug="-x" bash $debug scriptmake_with_flags() { [ "$debug" = "yes" ] && set -- -d "$@" make -j 5 -B "$@" } make_with_flags fileoptions=(-j 5 -B) # ksh88: set -A options -- -j 5 -B $debug == "yes" && options=("${options[@]}" -d) make "${options[@]}" fil

Add a custom sidebar

Clone this wiki locally