Skip to content

fix(formbuilder): update tooltips under some formbuilder buttons DEV-1522 #6582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
duvld wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(formbuilder): update tooltips under some formbuilder buttons DEV-1522 #6582

duvld wants to merge 3 commits into from
+2 −2

Conversation

@duvld
Copy link
Member

@duvld duvld commented Jan 5, 2026

🗒️ Checklist

  1. run linter locally
  2. update developer docs (API, README, inline, etc.), if any
  3. for user-facing doc changes create a Zulip thread at #Support Docs Updates, if any
  4. draft PR with a title <type>(<scope>)<!>: <title> DEV-1234
  5. assign yourself, tag PR: at least Front end and/or Back end or workflow
  6. fill in the template below and delete template comments
  7. review thyself: read the diff and repro the preview as written
  8. open PR & confirm that CI passes & request reviewers, if needed
  9. delete this section before merging

📣 Summary

Formbuilder header buttons had some incorrect tooltip, this PR updates them to at least be relevant to the button they're associated with

👀 Preview steps

  1. ℹ️ have an account and a project
  2. go to formbuilder
  3. hover over the "Add to library" and "Layout and settings" buttons
  4. 🔴 [on main] notice that the tooltips say "Insert cascading select"
  5. 🟢 [on PR] notice that the tooltips are relevant to the buttons

@duvld duvld self-assigned this Jan 5, 2026
@duvld duvld added the Front end label Jan 5, 2026
@duvld duvld requested a review from magicznyleszek as a code owner January 5, 2026 17:33
@duvld duvld changed the title fix(formbuilder) update tooltips under some formbuilder buttons fix(formbuilder) update tooltips under some formbuilder buttons DEV-1522 Jan 5, 2026
Akuukis
Akuukis requested changes Jan 5, 2026
View reviewed changes
jsapp/js/editorMixins/editableForm.js Outdated
Comment on lines 686 to 689
tooltip={t('Change form layout and settings')}
tooltipPosition='left'
startIcon={this.state.asideLayoutSettingsVisible ? 'close' : 'settings'}
label={this.hasMetadataAndDetails() ? t('Layout & Settings') : t('Layout')}
Copy link
Contributor

@Akuukis Akuukis Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

label is conditional, shouldn't the tooltip be as well?

Copy link
Member Author

@duvld duvld Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, will fix

Akuukis
Akuukis approved these changes Jan 5, 2026
View reviewed changes
Copy link
Contributor

@Akuukis Akuukis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not tested

@duvld duvld changed the title fix(formbuilder) update tooltips under some formbuilder buttons DEV-1522 fix(formbuilder): update tooltips under some formbuilder buttons DEV-1522 Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@magicznyleszek magicznyleszek magicznyleszek approved these changes

@Akuukis Akuukis Akuukis approved these changes

Assignees

@duvld duvld

Labels

Front end

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@duvld @magicznyleszek @Akuukis