Skip to content

Conversation

@RuthTurk
Copy link
Member

@RuthTurk RuthTurk commented Jan 6, 2026

📣 Summary

Allow users to add hints to forms which have translations before deploying the form.

💭 Notes

Also fixes DEV-1385 (Translation gets removed when saving a form with text question)

👀 Preview steps

  1. ℹ️ Create a form (undeployed).
  2. Add a default language and a new language. (ex: [English (en), French (fr)] )
  3. Return to the Formbuilder, add a hint or guidance hint.
  4. Exit Formbuilder.
  5. 🔴 [on main] Notice there is a new unnamed language and that the second language has been removed.
  6. 🟢 [on PR] Notice that both original languages are present.
  7. Return to Formbuilder.
  8. 🔴 [on main] Notice the Formbuilder is has an error and is inaccessible due to the unnamed language
  9. 🟢 [on PR] Notice that the Formbuilder has no errors and you can edit the survey normally

@RuthTurk RuthTurk self-assigned this Jan 6, 2026
@RuthTurk RuthTurk requested review from magicznyleszek and removed request for jnm and noliveleger January 6, 2026 20:08
Copy link
Member

@magicznyleszek magicznyleszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the problem(s) :) Tested it locally, can't say anything about the code other than "looks nice" :D

Also since this fixes the other problem too, I've edited the title to include both ids

@magicznyleszek magicznyleszek changed the title fix(asset): prevent translation errors after adding hints to a form DEV-1363 fix(asset): prevent translation errors after adding hints to a form DEV-1363 DEV-1385 Jan 7, 2026
@RuthTurk RuthTurk requested a review from rajpatel24 January 7, 2026 14:21
@RuthTurk RuthTurk merged commit e3694f7 into main Jan 7, 2026
11 checks passed
@RuthTurk RuthTurk deleted the ruthturk/dev-1363 branch January 7, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants