Skip to content

chore(claude): review harness - #71

Merged
koh-sh merged 7 commits into
mainfrom
chore/harness-review-2026-11-08
Nov 8, 2026
Merged

koh-sh merged 7 commits into
mainfrom
chore/harness-review-2026-11-08

Conversation

@koh-sh

@koh-sh koh-sh commented Nov 8, 2026 •

Copy link
Copy Markdown
Owner

Harness review of CLAUDE.md, .claude/ and the new e2e/CLAUDE.md, from /doctor, /doctor prompt-audit, /fewer-permission-prompts, /insights and claude plugin validate.

Adopted changes

# Change Evidence
1 kong-cli.md: the "switch on the command string" pattern is from Kong's own README This repo's README never mentions switch ctx.Command() or Kong
2 kong-cli.md: name VersionCmd.Run as the existing exception to "no method bodies in cmd/cli.go" func (v *VersionCmd) Run is at cmd/cli.go:63; it predates the rule
3 CLAUDE.md: add vhs to the mise-managed tools .mise.toml:11
4 CLAUDE.md: add mise run demo / demo-validate to the command list .mise.toml:86-95
5 CLAUDE.md: only commands with cross-field constraints have Validate() Validate() exists on ReviewCmd, PRCmd, LocateCmd only
6 upgrade-tools skill: update every bun-version in e2e.yml Two occurrences (e2e.yml:36, :65), one per job
7 CLAUDE.md: mark the hook overview, data flow and three design decisions as deprecated cchook, in the past tense README marks cchook/cclocate deprecated; CLAUDE.md did so only in the CLI and package sections, and plan-mode-based proposals came up in past sessions
8 CLAUDE.md: edit files with the Edit tool, not perl/sed in-place substitution Past sessions in this repo had perl substitutions corrupt files (a wrong delimiter broke a Go test file)
12 CLAUDE.md: drop seven generic rules (Go idioms, DRY, naming, comments, concise README) /doctor: behavior the model follows by default (~130 tokens per session)
13 Move the E2E test notes to e2e/CLAUDE.md /doctor: loaded only when working under e2e/ (~340 tokens off other sessions)
14 Add .claude/settings.json with five read-only Go commands; go doc -http and go list -mod…/-modfile still prompt via ask rules /fewer-permission-prompts: go doc 95, go build ./... 51, go list -m 17, go vet ./... 16, go tool cover -func=coverage.out 4 uses. go doc -http serves HTTP and -modfile may write go.mod (go help doc, go help build)

mise run ci passes.

Not adopted

Verification in a new session

The harness loads at session start, so check these in a fresh session:

🤖 Generated with Claude Code

https://claude.ai/code/session_01RKh8XqY1bD6M11zbzS4gVD

koh-sh and others added 5 commits November 8, 2026 22:52
- kong-cli rule: the "switch on the command string" pattern comes from
  Kong's own README, not this repository's
- kong-cli rule: name VersionCmd.Run as the existing exception to the
  "no method bodies in cmd/cli.go" rule
- upgrade-tools skill: e2e.yml has one bun-version per job, update all
- CLAUDE.md: add vhs to the mise tools and the demo / demo-validate
  tasks to the command list; only commands with cross-field
  constraints have Validate()

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RKh8XqY1bD6M11zbzS4gVD
cchook and cclocate were deprecated, but the project overview, the hook
data flow and three key design decisions still described the plan-mode
hook as a current, recommended feature. Label each of them deprecated
so new work does not build on the plan-mode flow.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RKh8XqY1bD6M11zbzS4gVD
In-place perl substitutions have corrupted files in this repository
(a wrong delimiter broke a Go test file). Edit them with the Edit tool.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RKh8XqY1bD6M11zbzS4gVD
- Drop the generic coding rules (Go idioms, DRY, naming, comments,
  concise README) that the model follows by default; keep the
  project-specific ones
- Move the E2E test notes to e2e/CLAUDE.md, which Claude Code loads
  only when working under e2e/, so other sessions do not carry them

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RKh8XqY1bD6M11zbzS4gVD
Allow the read-only Go commands that come up most often (go doc,
go build ./..., go list -m, go vet ./..., go tool cover -func) so
sessions without a local settings file stop prompting for them.
Exact matches keep -toolexec, -vettool and -o from being appended.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RKh8XqY1bD6M11zbzS4gVD
@github-actions

This comment has been minimized.

koh-sh and others added 2 commits November 8, 2026 22:59
go doc -http starts an HTTP server, and go list -mod=mod / -modfile can
rewrite go.mod, so the allowlisted wildcards were broader than
read-only. Route those flags back to a permission prompt.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RKh8XqY1bD6M11zbzS4gVD
- Describe the deprecated cchook triggers in the past tense instead of
  calling a deprecated hook "recommended"
- VersionCmd.Run is short, not three lines

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RKh8XqY1bD6M11zbzS4gVD
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown

Code Metrics Report

main (c01578d) #71 (a87f869) +/-
Coverage 91.5% 91.5% 0.0%
Code to Test Ratio 1:1.5 1:1.5 0.0
Test Execution Time 6s 5s -1s
Details
  |                     | main (c01578d) | #71 (a87f869) | +/-  |
  |---------------------|----------------|---------------|------|
  | Coverage            |          91.5% |         91.5% | 0.0% |
  |   Files             |             45 |            45 |    0 |
  |   Lines             |           3168 |          3168 |    0 |
  |   Covered           |           2899 |          2899 |    0 |
  | Code to Test Ratio  |          1:1.5 |         1:1.5 |  0.0 |
  |   Code              |           6575 |          6575 |    0 |
  |   Test              |          10261 |         10261 |    0 |
+ | Test Execution Time |             6s |            5s |  -1s |

Reported by octocov

@koh-sh
koh-sh merged commit 0591673 into main Nov 8, 2026
11 checks passed
@koh-sh
koh-sh deleted the chore/harness-review-2026-11-08 branch November 8, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant