Repository navigation
chore(claude): review harness - #71
Merged
Merged
Conversation
- kong-cli rule: the "switch on the command string" pattern comes from Kong's own README, not this repository's - kong-cli rule: name VersionCmd.Run as the existing exception to the "no method bodies in cmd/cli.go" rule - upgrade-tools skill: e2e.yml has one bun-version per job, update all - CLAUDE.md: add vhs to the mise tools and the demo / demo-validate tasks to the command list; only commands with cross-field constraints have Validate() Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RKh8XqY1bD6M11zbzS4gVD
cchook and cclocate were deprecated, but the project overview, the hook data flow and three key design decisions still described the plan-mode hook as a current, recommended feature. Label each of them deprecated so new work does not build on the plan-mode flow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RKh8XqY1bD6M11zbzS4gVD
In-place perl substitutions have corrupted files in this repository (a wrong delimiter broke a Go test file). Edit them with the Edit tool. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RKh8XqY1bD6M11zbzS4gVD
- Drop the generic coding rules (Go idioms, DRY, naming, comments, concise README) that the model follows by default; keep the project-specific ones - Move the E2E test notes to e2e/CLAUDE.md, which Claude Code loads only when working under e2e/, so other sessions do not carry them Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RKh8XqY1bD6M11zbzS4gVD
Allow the read-only Go commands that come up most often (go doc, go build ./..., go list -m, go vet ./..., go tool cover -func) so sessions without a local settings file stop prompting for them. Exact matches keep -toolexec, -vettool and -o from being appended. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RKh8XqY1bD6M11zbzS4gVD
This comment has been minimized.
This comment has been minimized.
go doc -http starts an HTTP server, and go list -mod=mod / -modfile can rewrite go.mod, so the allowlisted wildcards were broader than read-only. Route those flags back to a permission prompt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RKh8XqY1bD6M11zbzS4gVD
- Describe the deprecated cchook triggers in the past tense instead of calling a deprecated hook "recommended" - VersionCmd.Run is short, not three lines Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RKh8XqY1bD6M11zbzS4gVD
Code Metrics Report
Details | | main (c01578d) | #71 (a87f869) | +/- |
|---------------------|----------------|---------------|------|
| Coverage | 91.5% | 91.5% | 0.0% |
| Files | 45 | 45 | 0 |
| Lines | 3168 | 3168 | 0 |
| Covered | 2899 | 2899 | 0 |
| Code to Test Ratio | 1:1.5 | 1:1.5 | 0.0 |
| Code | 6575 | 6575 | 0 |
| Test | 10261 | 10261 | 0 |
+ | Test Execution Time | 6s | 5s | -1s |Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harness review of
CLAUDE.md,.claude/and the newe2e/CLAUDE.md, from/doctor,/doctor prompt-audit,/fewer-permission-prompts,/insightsandclaude plugin validate.Adopted changes
kong-cli.md: the "switch on the command string" pattern is from Kong's own READMEswitch ctx.Command()or Kongkong-cli.md: nameVersionCmd.Runas the existing exception to "no method bodies incmd/cli.go"func (v *VersionCmd) Runis atcmd/cli.go:63; it predates the ruleCLAUDE.md: addvhsto the mise-managed tools.mise.toml:11CLAUDE.md: addmise run demo/demo-validateto the command list.mise.toml:86-95CLAUDE.md: only commands with cross-field constraints haveValidate()Validate()exists onReviewCmd,PRCmd,LocateCmdonlyupgrade-toolsskill: update everybun-versionine2e.ymle2e.yml:36,:65), one per jobCLAUDE.md: mark the hook overview, data flow and three design decisions as deprecatedcchook, in the past tensecchook/cclocatedeprecated; CLAUDE.md did so only in the CLI and package sections, and plan-mode-based proposals came up in past sessionsCLAUDE.md: edit files with the Edit tool, notperl/sedin-place substitutionCLAUDE.md: drop seven generic rules (Go idioms, DRY, naming, comments, concise README)/doctor: behavior the model follows by default (~130 tokens per session)e2e/CLAUDE.md/doctor: loaded only when working undere2e/(~340 tokens off other sessions).claude/settings.jsonwith five read-only Go commands;go doc -httpandgo list -mod…/-modfilestill prompt viaaskrules/fewer-permission-prompts:go doc95,go build ./...51,go list -m17,go vet ./...16,go tool cover -func=coverage.out4 uses.go doc -httpserves HTTP and-modfilemay write go.mod (go help doc,go help build)mise run cipasses.Not adopted
commd prsubcommand for reviewing GitHub PR markdown files #10 Remove the Build & Test Commands section: loses notesmise tasksdoes not show (e.g. e2e vs e2e-basic)ReviewStatesave rules, the web session token) that is costly to rediscoverVerification in a new session
The harness loads at session start, so check these in a fresh session:
cmd/, the model does not look for a switch pattern in this README and does not flagVersionCmd.Runas a violationvhs/demoas project tooling and does not addValidate()toHookCmd/VersionCmd/upgrade-toolswith a bun bump updates bothbun-versionlines ine2e.ymlperl -pi/sed -i/contextat session start no longer lists the E2E notes; after reading a file undere2e/,e2e/CLAUDE.mdis loadedgo doc …/go build ./...run without a permission prompt in a checkout without.claude/settings.local.json(e.g. a worktree), whilego doc -httpstill prompts🤖 Generated with Claude Code
https://claude.ai/code/session_01RKh8XqY1bD6M11zbzS4gVD