Add Playwright E2E tests#9
Open
kokoichi206 wants to merge 2 commits into
Open
Conversation
- Add Playwright with persistent context to load the extension in Chromium - Test content script injection, rule matching (urlOnly, signals with meta/domTextRegex/titleRegex/selectorText extractors), priority ordering, display styles (topBar/ribbon/combo), and disabled rules - Test options page CRUD (add/edit/delete/toggle/export/display style) - Test storage sync between options page and content script - Add CI e2e job using pre-built artifact from test-and-build job - Change Shadow DOM from closed to open for test accessibility - Default to headless via --headless=new, HEADED=1 for headed mode Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Filter service workers by chrome-extension:// URL with timeout - Add comment explaining headless:false + --headless=new requirement - Switch npx to pnpm exec for lockfile-consistent execution - Add trace: retain-on-failure for CI debugging - Upload playwright-report artifact on failure Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--headless=newでヘッドレス実行）Changes
playwright.config.tse2e/fixtures/extension.tse2e/fixtures/test-rules.tse2e/pages/*.htmle2e/specs/content-script.spec.tse2e/specs/rule-matching.spec.tse2e/specs/options-page.spec.tse2e/specs/storage-sync.spec.tssrc/content/ui/overlay.ts.github/workflows/ci.ymlpackage.jsonTest plan
pnpm test— 既存ユニットテスト 60件パスpnpm test:e2e— E2E テスト 22件パス（ヘッドレス）🤖 Generated with Claude Code