fix: preserve base URL path segments in buildUrl() for Managed Dynatrace hosts

[github-actions]

Problem

dynatrace commands fail with HTTP 404 when baseUrl includes a path component (e.g. https://dynatrace.imagile.dev/e/abc12345-0000-0000-0000-000000000000 for Dynatrace Managed multi-environment clusters). The /e/<environment-id> segment was silently dropped, so requests landed at https://dynatrace.imagile.dev/api/v2/entities instead of the correct https://dynatrace.imagile.dev/e/abc12345-0000-0000-0000-000000000000/api/v2/entities.

This is the same root cause as BUG-4 (Artifactory baseUrl-with-path, fixed in PR #94): buildUrl() calls new URL(path, base) where path starts with /. Per the WHATWG URL spec, an absolute-path reference resolves against the origin, discarding any path already present in base.

Fix

Strip a single leading / from path inside the shared buildUrl() function in src/lib/http.ts before constructing the URL. Because buildUrl() already ensures base ends with /, the resulting relative path resolves correctly against the full base (including any path component).

PR #94 worked around BUG-4 by removing the leading slash from Artifactory path constants, leaving the underlying flaw in buildUrl() itself. This fix closes that gap at the source so future services with context-root base URLs don't hit it again.

Changes

• src/lib/http.ts — buildUrl(): strip leading / from path before new URL()
• src/lib/http.test.ts — new test: Dynatrace Managed base URL preserves /e/<environment-id> path segment

Verification

npm run typecheck  ✓
npm run lint       ✓
npm test           ✓  397 tests pass

Closes #283

Generated with Claude Code

[claude]

Claude finished @github-actions[bot]'s task in 2m 26s —— View job

---

PR Review

• Clean up previous Claude comments
• Read changed files (src/lib/http.ts, src/lib/http.test.ts)
• Review the fix for correctness and edge cases
• Submit formal review

---

PASS — Clean fix, correct analysis, solid test.

Root cause

The diagnosis is accurate. new URL('/api/v2/entities', 'https://host/e/env-id/') resolves against the origin per the WHATWG URL spec, silently dropping /e/env-id — the same class of bug that hit Artifactory in PR #94. Fixing it once in buildUrl() is the right call.

Fix (src/lib/http.ts lines 46–50)

const normalizedPath = path.startsWith('/') ? path.slice(1) : path;
const url = new URL(normalizedPath, normalizedBase);

Correct. Because normalizedBase always ends with /, a relative path resolves against the full base including any path segments.

Backward-compat check: Services whose base URLs are bare origins (https://jira.example.com) are unaffected — stripping / from /rest/api/2/... against https://jira.example.com/ produces the same URL as before.

Artifactory: PR #94 removed leading slashes from Artifactory path constants, so they enter buildUrl() without / — the ternary is a no-op and the existing test at line 354 still passes.

ADO percent-encoding: The ADO double-encode test (/myorg/My%20Project/...) still passes because the base URL has no path component; the result is identical with or without stripping the leading /.

Test (src/lib/http.test.ts lines 685–703)

The new test covers the exact failure case — Dynatrace Managed base URL with /e/<env-id> path, path argument /api/v2/entities, expected merged URL. It follows the established vi.stubGlobal('fetch', ...) pattern used throughout the suite.

One minor observation: no test asserts the platform-URL variant (dynatracePlatform) with a path-component base, but given dynatraceRequest() is the shared implementation for both, the coverage is sufficient.

No issues found

[claude]

PASS — Clean fix at the right layer. Root cause correctly identified (WHATWG URL spec absolute-path reference discards base path segments). Stripping a leading / from path in buildUrl() before constructing new URL() is the minimal correct fix. Backward-compatible for all existing services with bare-origin base URLs. New test directly exercises the Dynatrace Managed multi-environment URL pattern. 397 tests pass. Good to merge.