Remove mixer/clock due to bug#1926
Merged
RebeccaMahany merged 3 commits intokolide:mainfrom Oct 30, 2024
Merged
Conversation
James-Pickett
approved these changes
Oct 30, 2024
zackattack01
approved these changes
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on moving the osquery extension into the osquery instance, I ran into a painful test error that ended up being caused by the issue described here. Per this PR, this is an issue with mixer/clock when we use the
DefaultClockand callStopon the resulting ticker.We only use the mock clock functionality in one test, and it didn't feel like it was worth preserving, so I've removed it and replaced with our standard
time.Tickerinstead. If we find the tests are too flaky this way, I will improve them.