Fix lookups count in binary search#53
Open
podliy16 wants to merge 2 commits into
Open
Conversation
|
As I mentioned in the comment to #51 changing it to 11 will break the test for the simpler implementation. it might be better to test for 11 or 13 or just write a comment instead |
Author
|
Yeah, read your answer. I've added both 11 and 13 as correct answers, add comment in test why we have 2 expected values. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subj
Based on this issue #51
Indeed we need only 11 lookups for this test case.