Skip to content

Fix rememberViewStore autoClose ownership#265

Merged
hkusu merged 1 commit into
mainfrom
codex/fix-viewstore-autoclose-ownership
May 26, 2026
Merged

Fix rememberViewStore autoClose ownership#265
hkusu merged 1 commit into
mainfrom
codex/fix-viewstore-autoclose-ownership

Conversation

@hkusu
Copy link
Copy Markdown
Member

@hkusu hkusu commented May 26, 2026

Summary

  • apply autoClose per remembered Store instead of fixing it once per rememberViewStore call
  • document the close ownership behavior in rememberViewStore KDoc
  • add JVM tests for same-Store recomposition and key-based Store replacement

Why

  • keep disposal ownership stable for the same Store across recompositions
  • let a newly remembered Store pick up the current autoClose value after a key change

Verification

  • JAVA_HOME=/Users/h_kusu/Library/Java/JavaVirtualMachines/AndroidStudio/Contents/Home ./gradlew :koma-compose:jvmTest --tests io.github.komakt.koma.compose.ViewStoreJvmTest

@hkusu hkusu marked this pull request as ready for review May 26, 2026 02:14
@hkusu hkusu enabled auto-merge May 26, 2026 02:14
@hkusu hkusu merged commit 95bc951 into main May 26, 2026
5 checks passed
@hkusu hkusu deleted the codex/fix-viewstore-autoclose-ownership branch May 26, 2026 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant