Skip to content

Reset ViewStore state when store changes#267

Open
hkusu wants to merge 1 commit into
mainfrom
codex/viewstore-state-per-store
Open

Reset ViewStore state when store changes#267
hkusu wants to merge 1 commit into
mainfrom
codex/viewstore-state-per-store

Conversation

@hkusu
Copy link
Copy Markdown
Member

@hkusu hkusu commented May 26, 2026

Summary

  • recreate the Compose state holder when rememberViewStore adopts a different Store
  • add a regression test that verifies the first composition after a key change reads the new Store state

Why

  • keep state identity aligned with dispatch and event bindings on a per-Store basis
  • avoid carrying state across Store switches

Testing

  • JAVA_HOME=/Users/h_kusu/Library/Java/JavaVirtualMachines/AndroidStudio/Contents/Home ./gradlew :koma-compose:jvmTest

@hkusu hkusu marked this pull request as ready for review May 26, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant