Skip to content

Fix/mobile menu resize bug #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
komalharshita merged 2 commits into from
Jun 3, 2026
Merged

Fix/mobile menu resize bug #455

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6584be5
fix: close mobile menu on desktop resize view
pari-dubey1 Jun 3, 2026
609fec3
Merge branch 'main' into fix/mobile-menu-resize-bug
pari-dubey1 Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 22 additions & 14 deletions static/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ var errorMsg = document.getElementById('github-modal-error');
// ============================================================
(function initMobileNav() {
var toggle = document.getElementById("nav-mobile-toggle"); //hamburger button
var menu = document.getElementById("nav-mobile-menu"); //dropdown menu
var menu = document.getElementById("nav-mobile-menu"); //dropdown menu

// Nothing to do if the nav isn't on this page, just bail out
if (!toggle || !menu) return;
Expand All @@ -217,6 +217,14 @@ var errorMsg = document.getElementById('github-modal-error');
toggle.setAttribute("aria-expanded", "false");
});
});

window.addEventListener("resize", function () {
if (window.innerWidth >= 640) {
menu.classList.remove("open");
toggle.classList.remove("open");
toggle.setAttribute("aria-expanded", "false");
}
});
})();


Expand All @@ -227,19 +235,19 @@ if (isIndexPage) {

// DOM references
// grabbing all the elements we'll need so we're not calling getElementById over and over again throughout the code
var form = document.getElementById("recommend-form");
var submitBtn = document.getElementById("submit-btn");
var btnLabel = document.getElementById("btn-label"); // "get recommendations" text
var btnLoading = document.getElementById("btn-loading"); // spinner icon inside the button
var resultsSection = document.getElementById("results-section");
var resultsGrid = document.getElementById("results-grid");
var resultsLoadingEl = document.getElementById("results-loading"); // "Loading..." text in the results
var resultsEmptyEl = document.getElementById("results-empty");
var emptyMessageEl = document.getElementById("empty-message");
var skillsHidden = document.getElementById("skills"); // the hidden input that holds skills list
var skillsTextInput = document.getElementById("skills-input"); //visible text box in which user types skills
var chipsSelectedEl = document.getElementById("skill-chips-selected"); //selected skills tags container
var quickPickChips = document.querySelectorAll(".skill-chip"); // predefined skills user can click
var form = document.getElementById("recommend-form");
var submitBtn = document.getElementById("submit-btn");
var btnLabel = document.getElementById("btn-label"); // "get recommendations" text
var btnLoading = document.getElementById("btn-loading"); // spinner icon inside the button
var resultsSection = document.getElementById("results-section");
var resultsGrid = document.getElementById("results-grid");
var resultsLoadingEl = document.getElementById("results-loading"); // "Loading..." text in the results
var resultsEmptyEl = document.getElementById("results-empty");
var emptyMessageEl = document.getElementById("empty-message");
var skillsHidden = document.getElementById("skills"); // the hidden input that holds skills list
var skillsTextInput = document.getElementById("skills-input"); //visible text box in which user types skills
var chipsSelectedEl = document.getElementById("skill-chips-selected"); //selected skills tags container
var quickPickChips = document.querySelectorAll(".skill-chip"); // predefined skills user can click

// Tracks currently selected skills to prevent duplicates
var selectedSkills = [];
Expand Down
Loading