Fix invalid time_availability handling in recommender.py#669
Fix invalid time_availability handling in recommender.py#669mauliphad76 wants to merge 1 commit into
Conversation
|
@mauliphad76 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for the contribution. I reviewed the changes and appreciate the effort to make recommendation scoring more resilient to invalid inputs. However, this PR handles invalid values by silently returning a score of 0 instead of addressing validation at the input layer. In addition, the change introduces modifications to level and interest matching behavior that are outside the scope of the reported issue. The PR also does not include regression tests to verify the new behavior, which makes it difficult to validate the fix and prevent future regressions. Since this change overlaps with other validation-related improvements and lacks accompanying test coverage, I’m closing this pull request. Thank you for contributing to DevPath. |
Summary [required]
Related Issue [required]
Closes #
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
utils/recommender.pyclear_cache()functiontests/test_basic.pyHow to Test This PR [required]
git checkout your-branch-namepip install -r requirements.txtpython app.pypython tests/test_basic.pyExpected test output:
Test Results [required]
Screenshots (if UI change)
Self-Review Checklist [required]
feat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer