Skip to content

Fix dark mode functionality, accessibility support, and merge conflicts#717

Merged
komalharshita merged 2 commits into
komalharshita:mainfrom
SRSoham:darkmode-clean-v2
Jun 3, 2026
Merged

Fix dark mode functionality, accessibility support, and merge conflicts#717
komalharshita merged 2 commits into
komalharshita:mainfrom
SRSoham:darkmode-clean-v2

Conversation

@SRSoham
Copy link
Copy Markdown
Contributor

@SRSoham SRSoham commented Jun 2, 2026

Summary

This PR rebuilds the dark mode implementation cleanly on top of the latest main branch and resolves previous merge conflict issues.

Changes Made

  • Restored functional dark mode toggle
  • Added theme persistence using localStorage
  • Added accessibility improvements:
    • aria-label
    • aria-pressed
  • Added reduced motion support
  • Fixed merge conflict corruption in script.js
  • Cleaned duplicate CSS blocks and conflicting styles
  • Improved dark mode styling for:
    • forms
    • cards
    • buttons
    • inputs
    • skill chips
    • sections/navbar/footer

Testing

Tested locally and verified:

  • dark mode toggles correctly
  • theme persists after refresh
  • no layout breaking
  • responsive layout works correctly
  • form submission works properly
  • no console errors

Previous PR Reference

This PR supersedes the earlier conflicted PR:
#350

The previous branch encountered repeated merge conflicts after overlapping updates landed in the same sections. This branch rebuilds the implementation cleanly on top of the latest main branch.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 2, 2026

@SRSoham is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

@komalharshita
Copy link
Copy Markdown
Owner

Looks good to merge!

@komalharshita komalharshita merged commit c014a7b into komalharshita:main Jun 3, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants