feat: add parent snapshot data to the snapshot status#108
Merged
Conversation
14rcole
force-pushed
the
add-parent-snapshot-data
branch
2 times, most recently
from
70ec0aa to
3bc1798
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 6 6
Lines 470 505 +35
=====================================
- Misses 470 505 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Josh-Everett
approved these changes
May 29, 2026
kasemAlem
approved these changes
May 31, 2026
Contributor
Some ComponentGroups are composed of other ComponentGroups. When a child ComponentGroup has a snapshot created, the integration service's snapshot controller will create snapshots for all parents as well. The new status field tracks which parent ComponentGroups have had snapshots created and what those snaphots are called. This prevents the integration service's snapshot controller from creating duplicate parent snaphots. Signed-off-by: Ryan Cole <rcyoalne@gmail.com>
14rcole
force-pushed
the
add-parent-snapshot-data
branch
from
3bc1798 to
6b09e1d
Compare
Contributor
Author
|
@kasemAlem Good point, I can open a PR for that. In the meantime, I'll just tag the build team |
Contributor
Author
|
@konflux-ci/build-maintainers can you approve this? |
MartinBasti
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some ComponentGroups are composed of other ComponentGroups. When a child ComponentGroup has a snapshot created, the integration service's snapshot controller will create snapshots for all parents as well. The new status field tracks which parent ComponentGroups have had snapshots created and what those snaphots are called. This prevents the integration service's snapshot controller from creating duplicate parent snaphots.