feat: mobster enrich#377
Conversation
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
BorekZnovustvoritel
left a comment
There was a problem hiding this comment.
I mainly have minor things for discussion. However the test coverage decreased below 95 %, which fails the CI job. Some unit tests for all the new code should be added.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
==========================================
+ Coverage 94.94% 95.12% +0.18%
==========================================
Files 58 61 +3
Lines 3895 4082 +187
==========================================
+ Hits 3698 3883 +185
- Misses 197 199 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BorekZnovustvoritel
left a comment
There was a problem hiding this comment.
Thank you for addressing my comments. I have spoted some other minor things.
Also as you can see in the CI run I approved, Mobster enforces Conventional Commit messages for all commits in a PR. So the latest commit will have to be amended to change its description with fix: prefix.
Also if some of the code was assisted by AI, make sure to state that by adding a blank line and Assisted-by: <tool> to your commit messages.
Those are quite minor things, but we should get them addressed. Thank you for your work!
BorekZnovustvoritel
left a comment
There was a problem hiding this comment.
CI failed, fix with ruff format and ruff check --fix. Otherwise this looks good to me. We should also wait for Aleš to return from PTO to also take a look.
There was a problem hiding this comment.
Just a note: this is only used in examples, not tests.
However it isn't a large file, so I have no problem with keeping it this way.
|
Now the CI failure is not an issue stemming from your PR. I have created a fix PR to the main branch here. After it is merged, we need to rebase this PR on top of main. |
Documentation for the enrich feature lives in docs/sboms/enrich.md, and a comprehensive architecture explanation lives in docs/sboms/enrich_architecture.md.
This is an updated PR for the mobster enrich feature.
Main updates from last commit