Add colour controls for lights - #3
Closed
s3ansh33p wants to merge 1 commit into
Closed
Conversation
Expand a colour-capable light row with a hue/saturation wheel, the light's favourite colours, and a warmth slider for colour temperature. Capability comes from supported_color_modes, never a live hs_color: a colour light that is off reports none, which is exactly when the picker is wanted. Favourites come from the entity registry the panel already fetches, falling back to a port of the frontend's computeDefaultFavoriteColors so the swatches match the app's, and are normalized to hue/saturation or kelvin rather than carried as raw registry objects. Sliders and the wheel commit on release, as brightness does. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Merged
Contributor
Author
|
Closed as superseded by #4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effectively replicating the Home Assistant UI for colour-capable lights - includes hue/saturation wheel, the light's favourite colours, and a warmth slider for colour temperature.
Capability comes from supported_color_modes, never a live hs_color: a colour light that is off reports none, which is exactly when the picker is wanted. Favourites come from the entity registry the panel already fetches, falling back to a port of the frontend's
computeDefaultFavoriteColors so the swatches match the app's, and are normalized to hue/saturation or kelvin rather than carried as raw registry objects. Sliders and the wheel commit on release, as brightness does.