Skip to content

Optimistic controls #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
konradk merged 5 commits into from
Aug 17, 2026
Merged

Optimistic controls #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
95867e6
Add colour controls for lights
s3ansh33p Aug 15, 2026
7dacc84
Keep picked values on screen until the light confirms them
s3ansh33p Aug 15, 2026
f366e14
Snap a committed slider value onto the step grid its device declares
s3ansh33p Aug 17, 2026
6eb92f5
Treat a saved favourite colour list as a choice
s3ansh33p Aug 17, 2026
86bb4d8
Give every call its own tag so a refusal rolls back the right value
s3ansh33p Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion EntityStore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,11 @@ function projectRegistries(areas, entities, devices) {
}

var mapping = {}
// Home Assistant keeps per-light favourite colours in the registry entry's
// options, not on the entity state, so they are picked up here rather than
// from the state snapshot. Kept raw: Model validates each entry against the
// light's own capabilities before anything is drawn or sent.
var favorites = {}
var entityList = Array.isArray(entities) ? entities : []
for (var e = 0; e < entityList.length; e++) {
var entry = entityList[e]
Expand All @@ -86,8 +91,17 @@ function projectRegistries(areas, entities, devices) {
var inheritedArea = safeKey(entry.device_id) ? deviceArea[entry.device_id] : ""
var areaId = ownArea || inheritedArea || ""
if (areaId) mapping[entry.entity_id] = areaId

var options = entry.options
var lightOptions = options && typeof options === "object"
? options.light : null
var saved = lightOptions && typeof lightOptions === "object"
? lightOptions.favorite_colors : null
if (Array.isArray(saved)) {
favorites[entry.entity_id] = saved
}
}
return { areaNames: names, entityArea: mapping }
return { areaNames: names, entityArea: mapping, favoriteColors: favorites }
}

function sortedIds(states, displayName) {
Expand Down
Loading
Loading