Use Matchdep module to load installed Grunt plugins#4
Open
kadamwhite wants to merge 1 commit intokoop:masterfrom
kadamwhite:master
Open
Use Matchdep module to load installed Grunt plugins#4kadamwhite wants to merge 1 commit intokoop:masterfrom kadamwhite:master
kadamwhite wants to merge 1 commit intokoop:masterfrom
kadamwhite:master
Conversation
Calling `loadNpmTasks` for each Grunt plugin installed is duplicative, so Tyler Kellen created a matchdep package to allow Grunt to piggyback on the list of Grunt plugins saved in package.json. Using this module reduces boilerplate and makes it more obvious the package.json is the canonical list of installed plugins. Tyler's a Grunt team member and Ben's endorsed the syntax, so it's an officially-sanctioned approach.
|
I'm definitely a fan of matchdep since it does make the grunt file cleaner and more focused on the tasks at hand (pun intended). 👍 |
|
@kadamwhite I moved this ticket over to core trac since the develop repo is now live. http://core.trac.wordpress.org/ticket/24980 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
loadNpmTasksfor each Grunt plugin installed is duplicative, so Tyler Kellen created a matchdep package to allow Grunt to piggyback on the list of Grunt plugins saved in package.json. Using this module reduces boilerplate and makes it more obvious the package.json is the canonical list of installed plugins. Tyler's a Grunt team member and Ben's endorsed the syntax, so it's an officially-sanctioned approach.@aaronjorbin alerted me to this syntax, and it's been a huge help wherever I use Grunt. My devil's advocate response to this PR would be concern about adding yet another external module dependency vs using the more-verbose-but-honestly-what-are-ten-lines-among-friends Grunt-native syntax, but I think the clarity could be helpful.