Skip to content

fix(slo-config): add missing comma in system-config JSON example#337

Open
mdryaan wants to merge 1 commit into
koordinator-sh:mainfrom
mdryaan:fix/slo-config-json-syntax
Open

fix(slo-config): add missing comma in system-config JSON example#337
mdryaan wants to merge 1 commit into
koordinator-sh:mainfrom
mdryaan:fix/slo-config-json-syntax

Conversation

@mdryaan
Copy link
Copy Markdown

@mdryaan mdryaan commented May 16, 2026

Summary

  • Add missing comma after the clusterStrategy closing brace in the system-config JSON block — the JSON was syntactically invalid and would produce a parse
    error in koord-manager if copied into a ConfigMap as-is

Files Changed

  • docs/user-manuals/slo-config.md — added , after clusterStrategy closing } (line 316)
  • versioned_docs/version-v1.8/user-manuals/slo-config.md — same fix

Testing

  • npm run build passes locally
  • Checked versioned_docs/version-v1.8/ for same issue — fixed
  • Checked i18n/zh-Hans/ counterpart — both current/user-manuals/slo-config.md and version-v1.8/user-manuals/slo-config.md exist and have the same bug;
    translation team needs to apply the same comma fix

Related

Fixes #336

Signed-off-by: mdryaan <alikhurshid842001@gmail.com>
@koordinator-bot koordinator-bot Bot requested review from ZiMengSheng and hormes May 16, 2026 18:48
@koordinator-bot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign zimengsheng after the PR has been reviewed.
You can assign the PR to them by writing /assign @zimengsheng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mdryaan
Copy link
Copy Markdown
Author

mdryaan commented May 16, 2026

/assign @ZiMengSheng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

slo-config.md: system-config JSON example is missing a comma and will fail to parse

2 participants