fix(docs): update stale helm version and fix helms/Namepspace typos#339
Open
mdryaan wants to merge 1 commit into
Open
fix(docs): update stale helm version and fix helms/Namepspace typos#339mdryaan wants to merge 1 commit into
mdryaan wants to merge 1 commit into
Conversation
Signed-off-by: mdryaan <alikhurshid842001@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Author
|
/assign @ZiMengSheng |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--version 1.6.0to--version 1.8.0in the Batch Colocation Quick Start guideFiles Changed
docs/best-practices/batch-colocation-quick-start.md— updated Helm install version from 1.6.0 to 1.8.0docs/installation.md— fixed "helms" → "helm" in section headingdocs/user-manuals/colocation-profile.md— fixed "Namepspace" → "Namespace" in proseversioned_docs/version-v1.8/best-practices/batch-colocation-quick-start.md— same version fixversioned_docs/version-v1.8/installation.md— same heading fixversioned_docs/version-v1.8/user-manuals/colocation-profile.md— same typo fixTesting
npm run buildpasses locallyversioned_docs/version-v1.8/for same issues — all three fixedi18n/zh-Hans/counterparts — all three exist; translation team should apply the same fixes tocurrent/andversion-v1.8/zh-Hans filesRelated
Fixes #338