fix(workflow): unbound meta ReferenceError in sandbox (#17) - #18
Merged
Conversation
The Workflow sandbox keeps export const meta for UI metadata but does not bind meta in script scope, so meta.version threw ReferenceError on the first pipeline-state flush. Inject ENGINE_VERSION from plugin.json and ban meta.* accesses in the dist builder.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (14 files)
Reviewed by deepseek-v4-pro · Input: 67.8K · Output: 8.4K · Cached: 326.4K Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uncaught-throw: meta is not definedduring extract (and any consolidating mode) by stopping runtime use of the unboundmetaidentifier.const ENGINE_VERSION = '<plugin.json>';afterexport const meta; stamps/--resumeskew use that constant instead.\bmeta\.in the dist; adds regression + resume-skew tests.Closes #17
Test plan
npm test(194 pass)npm run validate:buildnpm run validate:versions1.4.5release (manual) and re-run/extract-designpast first slice consolidate