cljk-origin: record the 29 unregistered .cljk sources - #422
Merged
Merged
Conversation
The cljk mirror (network-awai/cloud-murakumo scripts/cljk-mirror.cljk) refuses a .cljk with no origin record, which blocks building the murakumo.cloud Worker. Origins are derived from file content following the existing practice in these repos (#? -> .cljc, js/node-only scripts -> .cljs, tests follow their subject); see the PR description for the weakly-evidenced entries. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
com-junkawasaki
changed the title
…ipt registrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
scripts/cljk-mirror.cljkin network-awai/cloud-murakumo (see network-awai/cloud-murakumo#254) mirrors every dependency to the extension it had before the.cljkrename so shadow-cljs can load it, and refuses when a.cljkfile has no entry in the repo'scljk-origin.edn. This repo has 29 such files, which blocks building the murakumo.cloud Worker frommain(The required namespace ... is not available).What
Only
cljk-origin.ednchanges (appended); no source or behaviour changes.scripts/web-cli.cljk.cljsscripts/web-crawl-demo.cljk.cljsscripts/web-fetch-demo.cljk.cljsscripts/web-fleet-health.cljk.cljsscripts/web-fleet-smoke.cljk.cljsscripts/web-recall-bench.cljk.cljsscripts/web-search-demo.cljk.cljssrc/murakumo/web.cljk.cljcsrc/murakumo/web/backends.cljk.cljcsrc/murakumo/web/crawl.cljk.cljcsrc/murakumo/web/dispatch.cljk.cljcsrc/murakumo/web/host.cljk.cljcsrc/murakumo/web/index.cljk.cljcsrc/murakumo/web/provision.cljk.cljcsrc/murakumo/web/robots.cljk.cljcsrc/murakumo/web/search.cljk.cljcsrc/murakumo/web/url.cljk.cljcsrc/murakumo/web/verify.cljk.cljcsrc/murakumo/web/worker.cljk.cljctest/murakumo/web_backends_test.cljk.cljctest/murakumo/web_crawl_test.cljk.cljctest/murakumo/web_host_test.cljk.cljstest/murakumo/web_index_test.cljk.cljctest/murakumo/web_provision_test.cljk.cljctest/murakumo/web_robots_test.cljk.cljctest/murakumo/web_search_test.cljk.cljctest/murakumo/web_test.cljk.cljctest/murakumo/web_verify_test.cljk.cljctest/murakumo/web_worker_test.cljk.cljsHow the extensions were chosen
For files created after the rename there is no
.cljc/.cljsancestor in git, so the value follows the existing practice in these repos:#?present ->.cljc; ascripts/file or one thatrequires anode:module ->.cljs;src/using onlyjs/->.cljc;test/using onlyjs/->.cljs; no platform evidence ->.cljc(tests follow their subject). Checked against 106 already-recorded files that carry such evidence: 86 agree (81%); the rule above is the one refined from the 20 that did not.Please confirm these
The origin of a file created after the rename cannot be read from history, so each is derived from its content. These are the ones where the evidence is weak:
src/murakumo/web/dispatch.cljk.cljc.cljcfor the 19 comparablesrc/files,.cljsfor 3src/murakumo/web/host.cljk.cljcjs/uses, no #?, nonode:requiresrc/murakumo/web/crawl.cljk.cljcsrc/murakumo/web/url.cljk.cljcsrc/murakumo/web/verify.cljk.cljctest/murakumo/web_host_test.cljk.cljstest/js-only files are.cljs5:1test/murakumo/web_worker_test.cljk.cljsChecked
cljk-origin.ednreads withkbband has the appended entries; every tracked*.cljkin the repo is now registered with.cljc/.cljs/.clj.CLJK_MIRROR_GUESS.🤖 Generated with Claude Code