Skip to content

SearchableList.async, async filter function #165

Closed
julien-levarlet wants to merge 6 commits into
koukibadr:mainfrom
julien-levarlet:feature/async_filter
Closed

SearchableList.async, async filter function #165
julien-levarlet wants to merge 6 commits into
koukibadr:mainfrom
julien-levarlet:feature/async_filter

Conversation

@julien-levarlet
Copy link
Copy Markdown
Contributor

Hi,
I made the changes from #162, the filter function is now async.
I also added a debouncer to make sure the filter function isn't called too often (can be tuned using asyncDebounceTime).

It's working, but I think it would be better if the asyncListFilter is canceled before calling it again, instead of calling it multiple times.

Comment thread lib/searchable_listview.dart Outdated
Comment thread lib/searchable_listview.dart Outdated
@koukibadr
Copy link
Copy Markdown
Owner

@julien-levarlet I did a full review to your PR but now I cannot rebase it there's conflict with main branch can you resolve it please

@julien-levarlet
Copy link
Copy Markdown
Contributor Author

@koukibadr, thank you,
I don't know why it doesn't work, it tells me that I am up-to-date with main.
If you prefer I can rebase my branch on main and push it in a new branch or force push in this branch. Is that better for you ?

@koukibadr
Copy link
Copy Markdown
Owner

@julien-levarlet yes the best way is the push it as a new branch rebased with main to make sure there's no conflicts
you can send me a new PR and we merge it directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants