Repository navigation
chore: Stop Loom from generating IntelliJ run configurations - #123
Merged
Merged
Conversation
The shared Gradle run configurations in .run/ start the client and the server of every version, so the Client, Server and Game Test configurations that Loom wrote into .idea/runConfigurations only duplicated them. Loom generates these only for the root project unless ideConfigGenerated is set, so the setting is removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
curvebuilding-fabricandfabric-test-runssetideConfigGenerated = true, so on every Gradle sync Loom wrote a Client, a Server and a Game Test configuration for each Minecraft version into.idea/runConfigurations(21 for the versions ofmain). They duplicated the shared Gradle configurations in.run/([runClient]and[runServer]of each version), and they stayed behind for versions that are no longer built in the checkout.generateRunConfigdefaults to whether the project is the root project (DefaultRunConfigurationSettings), so the version projects generate none. With none to generate, Loom disablesideaSyncTask.curvebuilding-fabric/build.gradlesays that IntelliJ IDEA runs these through.run/.ideConfigGeneratedis also deprecated in Loom in favor ofgenerateRunConfig.Configurations that Loom already wrote stay in
.idea/runConfigurationsuntil they are deleted by hand.How it was tested
./gradlew build checkCodeStyle --warning-mode all: the build and unit tests pass, with no Gradle, javac or Checkstyle warnings.--dry-runof:curvebuilding-fabric:26.3:runClient,:curvebuilding-fabric:1.21.1:runServer, and with-PtestRunsof:fabric-test-runs:26.1:runClientand:fabric-test-runs:1.21:runServer: the tasks of the shared configurations still resolve.Notes