Skip to content

Fix CI after landing the stack: scrollbar gutter only while a modal is open - #52

Merged
evangress merged 3 commits into
mainfrom
fix/ci-after-stack
Nov 12, 2026
Merged

evangress merged 3 commits into
mainfrom
fix/ci-after-stack

Conversation

@evangress

Copy link
Copy Markdown
Collaborator

CI on main failed after #51 (53 tests).

  • 51 Chromium tests: scrollbar-gutter: stable on the root. It reserved a scrollbar-wide strip on every page, so with classic scrollbars (the Linux runner, and real Windows and Linux visitors) every page was 15px narrower and short pages had an empty strip. The space is now kept only while a modal dialog is open, which is when the scrollbar goes away. A long page still doesn't shift when a modal opens. A short page with no scrollbar may shift once by the gutter's width on Windows and Linux.
  • Firefox, near-neutral colors: the test read Firefox's 5.96046e-8 as 5.96. The CSS was right; the test's pattern now accepts exponents.
  • Firefox, prefers-contrast: this has failed in CI since Chunk 23, later items: choice cards, pull quotes, data, embeds, pickers #46, before this work. The test now checks with matchMedia whether the emulation took effect, and skips if it didn't. If this run shows it skipped in Firefox, Playwright doesn't emulate the query there; if it fails, the CSS needs a look.

520 tests pass locally in Chromium and WebKit. Firefox can't launch in the local sandbox; this PR's CI is the check.

🤖 Generated with Claude Code

evangress and others added 3 commits November 10, 2026 19:59
…s open

- scrollbar-gutter: stable moves from :root to :root:has(dialog:modal).
  Always on, it gave every page an empty scrollbar-wide strip with classic
  scrollbars (Windows, Linux), and 51 width tests failed on the Linux runner.
- The near-neutral test read Firefox's exponent form (5.96046e-8) as 5.96.
- The prefers-contrast test skips where the browser doesn't emulate the
  query (checked with matchMedia at runtime); it has failed in Firefox on
  CI since #46.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Headless Chromium on Linux paints no scrollbar but still reserves
scrollbar-gutter space, so the no-shift check now only applies where a
scrollbar takes width, and the phone sheet is compared with the page's
width. Firefox under Playwright matches prefers-contrast in matchMedia
without restyling an open page, so the contrast test reloads first.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With the gutter kept while a modal is open, width: 100% left a strip at
the right edge where classic scrollbars reserve space.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@evangress
evangress merged commit 5f5262d into main Nov 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant