Repository navigation
Fix CI after landing the stack: scrollbar gutter only while a modal is open - #52
Merged
Merged
Conversation
…s open - scrollbar-gutter: stable moves from :root to :root:has(dialog:modal). Always on, it gave every page an empty scrollbar-wide strip with classic scrollbars (Windows, Linux), and 51 width tests failed on the Linux runner. - The near-neutral test read Firefox's exponent form (5.96046e-8) as 5.96. - The prefers-contrast test skips where the browser doesn't emulate the query (checked with matchMedia at runtime); it has failed in Firefox on CI since #46. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Headless Chromium on Linux paints no scrollbar but still reserves scrollbar-gutter space, so the no-shift check now only applies where a scrollbar takes width, and the phone sheet is compared with the page's width. Firefox under Playwright matches prefers-contrast in matchMedia without restyling an open page, so the contrast test reloads first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With the gutter kept while a modal is open, width: 100% left a strip at the right edge where classic scrollbars reserve space. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on
mainfailed after #51 (53 tests).scrollbar-gutter: stableon the root. It reserved a scrollbar-wide strip on every page, so with classic scrollbars (the Linux runner, and real Windows and Linux visitors) every page was 15px narrower and short pages had an empty strip. The space is now kept only while a modal dialog is open, which is when the scrollbar goes away. A long page still doesn't shift when a modal opens. A short page with no scrollbar may shift once by the gutter's width on Windows and Linux.5.96046e-8as5.96. The CSS was right; the test's pattern now accepts exponents.matchMediawhether the emulation took effect, and skips if it didn't. If this run shows it skipped in Firefox, Playwright doesn't emulate the query there; if it fails, the CSS needs a look.520 tests pass locally in Chromium and WebKit. Firefox can't launch in the local sandbox; this PR's CI is the check.
🤖 Generated with Claude Code