Repository navigation
fix(futures-paper): surface stop_price and trigger_signal in orders and order-status - #55
Closed
theghostmac wants to merge 1 commit into
Closed
theghostmac wants to merge 1 commit into
theghostmac wants to merge 1 commit into
Conversation
Contributor
|
Thanks @theghostmac! This is fixed in v0.5.0. |
needaccforwhonix
pushed a commit
to needaccforwhonix/kraken-cli
that referenced
this pull request
Nov 7, 2026
Sign in from the browser to create a restricted, expiring Spot API key. The MCP server and the REPL ship as their own binaries, kraken-mcp and kraken-shell, installed next to kraken. A paper strategy can go live in a budget-fenced workspace, and a finished session packages as a recipe. A timed-out order, cancel, withdrawal or transfer is never resent, and an envelope that may hide an execution carries "verify_first": true. Upgrading from 0.4.1 needs action from scripts, agents and MCP clients: see CHANGELOG.md under 0.5.0. Includes community fixes from krakenfx#50, krakenfx#51, krakenfx#54, krakenfx#55 and krakenfx#56. Co-authored-by: theghostmac <83423188+theghostmac@users.noreply.github.com> Co-authored-by: SashaMIT <33847880+SashaMIT@users.noreply.github.com> Co-authored-by: sashaphmn <122053040+sashaphmn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Surfaces
stop_priceandtrigger_signalin both the table and JSON outputs ofkraken futures paper ordersandkraken futures paper order-status.Problem
When a triggered futures paper order (
stop,take-profit, ortrailing-stop) is placed without a limit--price,order.priceisNonewhileorder.stop_priceandorder.trigger_signalhold the trigger parameters.Previously,
execute_ordersandexecute_order_statusinsrc/commands/futures_paper.rsonly projectedorder.price(—in table mode,nullin JSON mode) and omittedstop_priceandtrigger_signalentirely, making it impossible to inspect stop prices or trigger signals via the CLI or-o jsonwithout reading the rawfutures_state.jsonfile.Changes
Stop Price/Triggercolumns andstop_price/trigger_signalJSON fields tokraken futures paper orders.Stop Price/Trigger Signalkey-value rows andstop_price/trigger_signalJSON fields tokraken futures paper order-status.format_open_ordersandformat_order_statushelpers and add unit testorders_and_order_status_surface_stop_price_and_trigger_signal.Verification & CLI Proof
Before Fix
After Fix
Automated Tests & Lints
cargo +nightly fmt --checkcargo clippy --all-targets -- -D warningscargo test --lib orders_and_order_status_surface_stop_price_and_trigger_signal