Remove unused/deprecated dependencies, include recent GHCs/stack lts in CI config#69
Remove unused/deprecated dependencies, include recent GHCs/stack lts in CI config#69jhrcek wants to merge 10 commits intokrdlab:masterfrom
Conversation
| @@ -0,0 +1,221 @@ | |||
| # This GitHub workflow config has been generated by a script via | |||
There was a problem hiding this comment.
Adding CI config generated by haskell-ci.
Let me know if you don't like it - I can remove it.
But I have positive experience with it. You just add new ghc version to tested-with field in cabal file and regenerate the config.
| strategy: | ||
| matrix: | ||
| resolver: | ||
| - lts-17 |
There was a problem hiding this comment.
Dropped lts based on ghc 8.10.4.
I feel like nowadays it's reasonable to use ghc 8.10.7 as the oldest "tested" version.
| import Control.Monad.IO.Class (liftIO) | ||
| import Control.Monad.Reader (ReaderT, ask, lift, | ||
| runReaderT) | ||
| import Crypto.Random.AESCtr (AESRNG, makeSystem) |
There was a problem hiding this comment.
This and following are coming from https://hackage.haskell.org/package/cprng-aes-0.6.1 and https://hackage.haskell.org/package/crypto-random which are both deprecated, superseded by cryton.
|
I think it will be best to get rid of scotty-cookie, because more recent versions of scotty have cookie functionality built in. Marking this as a draft until I implement that simplification.. |
c28cbec to
0912db1
Compare
|
Ready for review. Rather than adding too many extra-deps for older stack resolvers just to make the examples work with stack, I decided to disable building examples with stack resolvers < lts-20. Let me know if you're ok with this tradeoff. |
ef070db to
a49585f
Compare
|
Hello @krdlab What I'd love to get merged:
What I consider as optional (and can remove from this PR if you prefer).
|
Hello 🙂
I'd like to use this package to implement SSO in my app.
But first, I'd like to get some reasonable assurance this package will keep working with more recent GHC versions.
I made the CI green with stack/cabal for all ghc versions from 8.10.7 - 9.8.2 - (see a PR in my fork)
While making the example work with more recent dependencies I also noticed there are few unused dependencies, which can be removed.
I also did some extra-deps shuffling to make sure the examples also work with more recent stack lts resolvers.