Skip to content

Update to ensure proper application order of parent permissions - #1

Open
dawninginnovations wants to merge 1 commit into
krinsdeath:masterfrom
dawninginnovations:master
Open

Update to ensure proper application order of parent permissions#1
dawninginnovations wants to merge 1 commit into
krinsdeath:masterfrom
dawninginnovations:master

Conversation

@dawninginnovations

Copy link
Copy Markdown

Greeting krinsdeath:

We make extensive use of parent permissions to get around some limitation imparted by McMyAdmin. Over the past couple of weeks, I've begun to notice that some of our permissions weren't taking, but had written it off to the CraftBukkit development release. I finally had some time to devote to this matter and traced it down to the manner in which permissions are collected within PermissionsBukkit. I forked your version and updated it accordingly. It has been extensively tested and you are more than welcome to incorporate the changes.

Best regards,

Frelling

permissions are applied in the correct order. See comments in
PermissionsPlugin for more details.
@krinsdeath

Copy link
Copy Markdown
Owner

@dawninginnovations

I haven't really been paying attention to this repo at all. I've got my own project Privileges for Permissions now. You're welcome to submit this pull to SpaceManiac, though.

Might want to clean up the code (reformat) before submitting it though, it's kinda messy.

@dawninginnovations

Copy link
Copy Markdown
Author

@krinsdeath

Thanks for the feedback. By "clean up code/messy" I take it that you mean the code in general, as opposed to implying that the mods I made are messy; though the over-lengthy comment block does need to be tailored and formatted.

@krinsdeath

Copy link
Copy Markdown
Owner

By messy, I am referring to the coding style. SpaceManiac wraps curly brackets around any if-statement, and indents with 4 spaces (no tabs). Other than that, the code itself is fine.

I am sorry if it seemed like I was saying your coding was poor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants