Update to ensure proper application order of parent permissions - #1
Open
dawninginnovations wants to merge 1 commit into
Open
Update to ensure proper application order of parent permissions#1dawninginnovations wants to merge 1 commit into
dawninginnovations wants to merge 1 commit into
Conversation
permissions are applied in the correct order. See comments in PermissionsPlugin for more details.
Owner
|
I haven't really been paying attention to this repo at all. I've got my own project Privileges for Permissions now. You're welcome to submit this pull to SpaceManiac, though. Might want to clean up the code (reformat) before submitting it though, it's kinda messy. |
Author
|
Thanks for the feedback. By "clean up code/messy" I take it that you mean the code in general, as opposed to implying that the mods I made are messy; though the over-lengthy comment block does need to be tailored and formatted. |
Owner
|
By messy, I am referring to the coding style. SpaceManiac wraps curly brackets around any if-statement, and indents with 4 spaces (no tabs). Other than that, the code itself is fine. I am sorry if it seemed like I was saying your coding was poor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greeting krinsdeath:
We make extensive use of parent permissions to get around some limitation imparted by McMyAdmin. Over the past couple of weeks, I've begun to notice that some of our permissions weren't taking, but had written it off to the CraftBukkit development release. I finally had some time to devote to this matter and traced it down to the manner in which permissions are collected within PermissionsBukkit. I forked your version and updated it accordingly. It has been extensively tested and you are more than welcome to incorporate the changes.
Best regards,
Frelling