Skip to content

Fix filtered scan startup and MPEG-TS worker playback - #213

Merged
kristofferR merged 2 commits into
mainfrom
agent/fix-scan-cache-playback-worker
Jul 24, 2026
Merged

Fix filtered scan startup and MPEG-TS worker playback#213
kristofferR merged 2 commits into
mainfrom
agent/fix-scan-cache-playback-worker

Conversation

@kristofferR

Copy link
Copy Markdown
Owner

Summary

  • derive group/name-filtered scan previews from the existing full in-memory preview cache
  • preserve stable channel indices, metadata, content counts, and directory group behavior
  • allow blob-backed MPEG-TS workers through the Tauri CSP
  • probe worker execution once and fall back to inline transmuxing if startup is blocked

Root cause

Filtered scan settings were part of the preview cache key, so the first scan after selecting a group or source filter missed the already-loaded full preview and reparsed very large playlists from disk.

MPEG-TS playback enabled the mpegts.js blob worker, but the app CSP did not permit blob workers. The asynchronous worker failure left mpegts.js waiting without ever requesting the localhost proxy/remux route.

Validation

  • bun run test:frontend — 90 passed
  • bun run typecheck
  • cargo test --manifest-path src-tauri/Cargo.toml test_filter_cached_preview_matches_filtered_parse
  • cargo check in src-tauri
  • bun tauri build --debug --bundles app
  • installed debug bundle passed strict local signature verification and launched successfully

CodeRabbit local preflight was attempted three times but the external review service exited during setup without returning findings.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@kristofferR, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 16 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 589b4485-ae2c-4f8e-85a3-8c32086c006c

📥 Commits

Reviewing files that changed from the base of the PR and between 5b8e5e9 and 2df1fb6.

📒 Files selected for processing (7)
  • src-tauri/src/commands/scan.rs
  • src-tauri/src/engine/parser.rs
  • src-tauri/src/state.rs
  • src-tauri/tauri.conf.json
  • src/hooks/useStreamPlayer.ts
  • src/lib/workerSupport.ts
  • tests/workerSupport.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/fix-scan-cache-playback-worker

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kristofferR

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@kristofferR

Copy link
Copy Markdown
Owner Author

@codex review

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1d7dc07054

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src-tauri/src/commands/scan.rs Outdated
Comment thread src-tauri/src/commands/scan.rs
Comment thread src-tauri/src/engine/parser.rs Outdated
@kristofferR

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@kristofferR

Copy link
Copy Markdown
Owner Author

@codex review

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 2df1fb6dfc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kristofferR
kristofferR merged commit 9f1e294 into main Jul 24, 2026
9 checks passed
@kristofferR
kristofferR deleted the agent/fix-scan-cache-playback-worker branch July 24, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant