Modernize the demo + fix some important issues - #25
Merged
Conversation
Signed-off-by: Nikita Vakula <programmistov.programmist@gmail.com>
Signed-off-by: Nikita Vakula <programmistov.programmist@gmail.com>
Signed-off-by: Nikita Vakula <programmistov.programmist@gmail.com>
* Replaces webpack with vite in library mode * jest becomes vitest, and typescript moves to 7 * The eslint setup is replaced by oxlint. typescript-eslint does not support typescript 7 * react-bootstrap is now external rather than bundled. * The babel toolchain, the testing-library packages and sinon are removed as unused * Prettier is added, which accounts for the reformatting across src. Signed-off-by: Nikita Vakula <programmistov.programmist@gmail.com>
Signed-off-by: Nikita Vakula <programmistov.programmist@gmail.com>
VirtualTable tracked the selected row internally and never exposed it, so consumers could only infer a selection from a handler inside their own rendered item. That misses rows clicked before their page has loaded: the row highlights, but the skeleton carries neither item nor index. Signed-off-by: Nikita Vakula <programmistov.programmist@gmail.com>
Signed-off-by: Nikita Vakula <programmistov.programmist@gmail.com>
Signed-off-by: Nikita Vakula <programmistov.programmist@gmail.com>
Signed-off-by: Nikita Vakula <programmistov.programmist@gmail.com>
Signed-off-by: Nikita Vakula <programmistov.programmist@gmail.com>
Signed-off-by: Nikita Vakula <programmistov.programmist@gmail.com>
That ensures that there is no division by 0. Signed-off-by: Nikita Vakula <programmistov.programmist@gmail.com>
Signed-off-by: Nikita Vakula <programmistov.programmist@gmail.com>
Signed-off-by: Nikita Vakula <programmistov.programmist@gmail.com>
Signed-off-by: Nikita Vakula <programmistov.programmist@gmail.com>
Signed-off-by: Nikita Vakula <programmistov.programmist@gmail.com>
The scrollbar came from a full-size div layered over the rows, so it swallowed every pointer event: content inside a row could not be clicked, text could not be selected, and the row under the cursor had to be worked out from clientY and a click synthesised onto it. The rows now live inside the scroll container, positioned within a spacer the height of the whole collection. Signed-off-by: Nikita Vakula <programmistov.programmist@gmail.com>
Signed-off-by: Nikita Vakula <programmistov.programmist@gmail.com>
Signed-off-by: Nikita Vakula <programmistov.programmist@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.