Adds the bind-to-interface helper code#5
Open
farcaller wants to merge 1 commit into
Open
Conversation
Typical UDP socket would listen on 0.0.0.0:67 and bind to an interface to limit exposure. This PR implements a helper method to bind and serve on a socket. Currently it’s linux only. I left an unimplemented!() trap for BSD with a note how to progress there and feature-gated the code.
krolaw
requested changes
Apr 5, 2017
Owner
krolaw
left a comment
There was a problem hiding this comment.
In my Go version, I went with the equivalent of bind_and_serve (called ServeIf), which I now believe was a mistake. In my private branch I've deprecated those functions - favouring a NewUDP4BoundConn(ifname string, addr string) fn, the result of which is passed to Serve. However, now I'm thinking, that such a general function deserves it's own lib, leaving the DHCP4r completely OS agnostic.
Contributor
Author
|
While I can agree that it could fit |
Contributor
Author
|
bump. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typical UDP socket would listen on 0.0.0.0:67 and bind to an interface
to limit exposure. This PR implements a helper method to bind and serve
on a socket.
Currently it’s linux only. I left an unimplemented!() trap for BSD with
a note how to progress there and feature-gated the code.