Skip to content

Add SBOM release metadata#2

Merged
krotname merged 1 commit into
masterfrom
feature/public-repo-polish-20260621
Jun 21, 2026
Merged

Add SBOM release metadata#2
krotname merged 1 commit into
masterfrom
feature/public-repo-polish-20260621

Conversation

@krotname

Copy link
Copy Markdown
Owner

Summary

  • add CycloneDX SBOM generation to release assets
  • include SBOM in checksums and GitHub release upload
  • make release provenance attestation mandatory
  • document release verification and supply-chain controls

Validation

  • workflow YAML parse and bash syntax checks
  • git diff --check

@codecov

codecov Bot commented Jun 20, 2026

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@krotname krotname marked this pull request as ready for review June 21, 2026 01:47
@krotname krotname merged commit c0900dc into master Jun 21, 2026
21 checks passed
@krotname krotname deleted the feature/public-repo-polish-20260621 branch June 21, 2026 01:49

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fdd1ad63c1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

uses: actions/attest@59d89421af93a897026c735860bf21b6eb4f7b26 # v4
with:
subject-path: release-files/*.zip
sbom-path: release-files/*-sbom.cdx.json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use a concrete SBOM path for attestation

In the release job, this action input is not run through a shell, so the * is passed literally to actions/attest. I checked the pinned action: only subject-path is documented as accepting globs, while sbom-path is read directly with fs.stat(filePath), which will fail here with SBOM file not found because the generated file is named MarkdownTableEditor-$VERSION-sbom.cdx.json. Any release that reaches this step will fail before publishing.

Useful? React with 👍 / 👎.

Comment on lines +143 to +146
{
"bomFormat": "CycloneDX",
"specVersion": "1.6",
"version": 1,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Include the CycloneDX serialNumber

After the SBOM path is made explicit, the generated CycloneDX document is still rejected by the same pinned actions/attest code: its CycloneDX detector requires bomFormat, serialNumber, and specVersion, but this JSON only emits bomFormat and specVersion. That makes the SBOM attestation fail with Unsupported SBOM format, blocking releases that use the new SBOM step.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant