Convert time.Time to UTC before formatting timestamp parameter - #12
Open
vlehto wants to merge 2 commits into
Open
Convert time.Time to UTC before formatting timestamp parameter#12vlehto wants to merge 2 commits into
vlehto wants to merge 2 commits into
Conversation
Convert incoming datetime value to UTC before formatting. Formatted timestamp does not use timezone, both MySQL and Aurora PostgreSQL default to UTC with naked datetime values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConvertNamedValueindialect.gonow calls.UTC()on the incomingtime.Timevalue before formatting it as a timestamp stringdialect_test.gocovering a non-UTC input (Europe/Helsinki) and a UTC inputTest plan
go test ./... -run Test_Dialectpasses — non-UTC time is shifted to UTC in the formatted string, UTC time is unchanged