Skip to content

fix: modal closing behavior with a file input#39

Merged
johnlcos merged 3 commits intomainfrom
feat/TRAIL__minor_updates
May 4, 2026
Merged

fix: modal closing behavior with a file input#39
johnlcos merged 3 commits intomainfrom
feat/TRAIL__minor_updates

Conversation

@johnlcos
Copy link
Copy Markdown
Member

@johnlcos johnlcos commented May 4, 2026

Summary

Fixes: #

Related Tickets: TRAIL-

  • Improves closing logic for the dialog. Specifically to prevent issues where closing a file upload dialog also closes the main modal.

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 📚 Documentation update
  • 🎨 Style/UI change
  • ♻️ Refactor (no functional changes)
  • ⚡ Performance improvement
  • 🧪 Test update
  • 🔧 Build/CI configuration
  • 🧹 Chore (dependency updates, cleanup, etc.)

Changes Made

Primary Changes

Secondary/Collateral Changes


Technical Notes

Files Modified

Implementation Details


Testing

How to Test

Test Coverage

  • Unit tests added/updated
  • Integration tests added/updated
  • E2E tests added/updated
  • Manual testing completed

Browsers Tested

  • Chrome
  • Firefox
  • Safari
  • Edge

Potential Regressions


Screenshots / Videos

Before After

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have updated documentation as needed
  • My changes generate no new warnings or errors
  • I have tested my changes locally
  • Any dependent changes have been merged and published

Additional Context

@johnlcos johnlcos requested review from Hannahbird May 4, 2026 15:27
Copy link
Copy Markdown
Collaborator

@Hannahbird Hannahbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlcos johnlcos merged commit 164ab77 into main May 4, 2026
3 of 4 checks passed
@johnlcos johnlcos deleted the feat/TRAIL__minor_updates branch May 4, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants