fix: restore open-external https regex#53
Merged
Conversation
Comment strip truncated /^https?:\/\//i and prevented the Electron main process from loading (#52).
krwg
commented
Jul 23, 2026
krwg
left a comment
krwg
left a comment
Owner
Author
There was a problem hiding this comment.
Notes:
- Only
main/index.jswas truncated; other main modules passnode --check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/^https?:\/\//iinopen-external(broken by earlier comment strip)npx electron .main-process loadCloses #52
Test plan
node --check main/index.jsnpx electron .starts without regex SyntaxErrornpm testgreenMade with Cursor