fix: record the demo GIF and clean up the Picker's exit - #51
Merged
Merged
Conversation
…e prompt on exit Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
VHS requires quoted strings for Env. v0.12.0 cancels its own context before rendering and silently produces no GIF; v0.11.0 works. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README linked
demo/demo.gifbut nothing had produced it. This PR adds the recording and fixes what recording it uncovered.fix(demo): the tape'sEnvvalues were unquoted, which VHS rejects. Also disables fish autosuggestions during the recording and documents that VHS v0.12.0 silently writes no GIF (it cancels its own context before calling ffmpeg); v0.11.0 works.fix(picker): the Picker now draws on the alternate screen. Inline rendering left two lines and a preview border fragment above the shell prompt after every Jump. A test pinsView().AltScreen.docs(demo):demo/demo.gif, 1200x640, 9 seconds, recorded against the throwaway environment fromdemo/setup.sh.🤖 Generated with Claude Code