This repository was archived by the owner on May 24, 2026. It is now read-only.
Add Arkveld encounter triggers and update version #220
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -165,6 +165,7 @@ const triggerSet: TriggerSet<Data> = { | |
| outputStrings: { | ||
| text: { | ||
| en: 'Check Boss HP Difference', | ||
| cn: '检查 BOSS 血量差', | ||
| ko: '보스 체력차 확인해요', | ||
| }, | ||
| }, | ||
|
|
@@ -183,6 +184,7 @@ const triggerSet: TriggerSet<Data> = { | |
| outputStrings: { | ||
| text: { | ||
| en: '${effect} on ${target}', | ||
| cn: '${effect} 点 ${target}', | ||
| ko: '${target}에게 ${effect}', | ||
| }, | ||
| }, | ||
|
|
@@ -212,6 +214,7 @@ const triggerSet: TriggerSet<Data> = { | |
| outputStrings: { | ||
| text: { | ||
| en: 'Refresh Vengeance', | ||
| cn: '刷新光/暗 Debuff', | ||
| ko: '벤젠스 갱신해둬요', | ||
| }, | ||
| }, | ||
|
|
@@ -243,6 +246,7 @@ const triggerSet: TriggerSet<Data> = { | |
| outputStrings: { | ||
| text: { | ||
| en: '${mech1} => ${mech2}', | ||
| cn: '${mech1} => ${mech2}', | ||
| ko: '${mech1} 🔜 ${mech2}', | ||
| }, | ||
| sides: Outputs.sides, | ||
|
|
@@ -271,6 +275,7 @@ const triggerSet: TriggerSet<Data> = { | |
| outputStrings: { | ||
| text: { | ||
| en: '${mech1} => ${mech2}', | ||
| cn: '${mech1} => ${mech2}', | ||
| ko: '${mech1} 🔜 ${mech2}', | ||
| }, | ||
| sides: Outputs.sides, | ||
|
|
@@ -306,6 +311,8 @@ const triggerSet: TriggerSet<Data> = { | |
| outputStrings: { | ||
| text: { | ||
| en: '${mech1} => ${mech2}', | ||
| cn: '${mech1} => ${mech2}', | ||
| ko: '${mech1} 🔜 ${mech2}', | ||
|
Comment on lines
+314
to
+315
There was a problem hiding this comment. Incomplete Korean localization: The Korean translation is missing for this line while Chinese was added. For consistency with the rest of the file, Korean localization should be included.
Owner
Author
There was a problem hiding this comment. ko resources always use '🔜' instead of '=>'. not same other locales |
||
| }, | ||
| sides: Outputs.sides, | ||
| middle: Outputs.goIntoMiddle, | ||
|
|
@@ -440,6 +447,7 @@ const triggerSet: TriggerSet<Data> = { | |
| outputStrings: { | ||
| text: { | ||
| en: '${frontBack}-${leftRight}, for later', | ||
| cn: '稍后去 ${leftRight}-${frontBack}', | ||
| ko: '(나중에 ${frontBack}+${leftRight})', | ||
| }, | ||
| front: Outputs.front, | ||
|
|
@@ -490,6 +498,7 @@ const triggerSet: TriggerSet<Data> = { | |
| outputStrings: { | ||
| text: { | ||
| en: '${frontBack}-${leftRight}, for later', | ||
| cn: '稍后去 ${leftRight}-${frontBack}', | ||
| ko: '(나중에 ${frontBack}+${leftRight})', | ||
| }, | ||
| front: Outputs.front, | ||
|
|
@@ -519,6 +528,7 @@ const triggerSet: TriggerSet<Data> = { | |
| outputStrings: { | ||
| text: { | ||
| en: '${frontBack}-${leftRight}, Avoid Exaflares', | ||
| cn: '在 ${leftRight}-${frontBack} 躲避地火', | ||
| ko: '${frontBack}+${leftRight}, 엑사플레어 피해요', | ||
| }, | ||
| front: Outputs.front, | ||
|
|
@@ -568,6 +578,7 @@ const triggerSet: TriggerSet<Data> = { | |
| outputStrings: { | ||
| text: { | ||
| en: 'Go ${dir}', | ||
| cn: '去 ${dir}', | ||
| ko: '가세요: ${dir}', | ||
| }, | ||
| unknown: Outputs.unknown, | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Visual Studio version path has been changed from "2022" to "18". This appears to be incorrect as Visual Studio 2026 (if it exists) would use version "2026", not "18". Visual Studio version numbers follow the pattern:
If this is intended to reference VS 2026, it should be "2026" not "18". Please verify the correct Visual Studio installation path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see this url: https://learn.microsoft.com/en-us/visualstudio/releases/2026/release-notes
version of vs2026 is 18