🎨 Palette: Add tooltips and ARIA labels to status buttons - #1275
Conversation
…mmary of the changes: 🎨 Palette: Add tooltips and ARIA labels to status buttons 💡 What: Added `title` and `aria-label` attributes to the status transition buttons (Mark as completed, Mark as won't do, Revert to todo). 🎯 Why: These are icon-only buttons. Adding ARIA labels makes them accessible to screen readers, and adding tooltips helps sighted users understand their function before clicking. 📸 Before/After: Not applicable (invisible attribute changes except for native tooltips on hover). ♿ Accessibility: Screen reader users can now understand the purpose of the status toggle buttons via their ARIA labels. Co-authored-by: kshramt <876546+kshramt@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 675c252379
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| onClick={on_click} | ||
| onDoubleClick={utils.prevent_propagation} | ||
| title="Revert to todo" | ||
| aria-label="Revert to todo" |
There was a problem hiding this comment.
Add tests for the accessible status-button labels
This commit adds the accessible names and tooltips to three status buttons without adding any corresponding component assertions, so a later change could silently remove or mismatch the labels while the existing suite continues to pass. Add coverage that renders each button and verifies its accessible name and tooltip.
AGENTS.md reference: AGENTS.md:L3-L3
Useful? React with 👍 / 👎.
🎨 Palette: Add tooltips and ARIA labels to status buttons
💡 What: Added
titleandaria-labelattributes to the status transition buttons (Mark as done, Mark as won't do, Revert to todo).🎯 Why: These are icon-only buttons. Adding ARIA labels makes them accessible to screen readers, and adding tooltips helps sighted users understand their function before clicking.
📸 Before/After: Not applicable (invisible attribute changes except for native tooltips on hover).
♿ Accessibility: Screen reader users can now understand the purpose of the status toggle buttons via their ARIA labels.
PR created automatically by Jules for task 8057565932040967427 started by @kshramt