Skip to content

Preserve current ARR settings when applying previews - #4

Merged
ksudo-dev merged 1 commit into
mainfrom
chore/postmerge-verify-provisionarr
Oct 3, 2026
Merged

ksudo-dev merged 1 commit into
mainfrom
chore/postmerge-verify-provisionarr

Conversation

@ksudo-dev

Copy link
Copy Markdown
Owner

Summary

  • refresh ARR settings immediately before applying a reviewed preview
  • create rollback backups from that fresh snapshot
  • preserve unrelated settings changed after preview creation

Validation

  • TAP version 13

Subtest: orchestration inventory is owner-only and never exposes upstream secrets

ok 1 - orchestration inventory is owner-only and never exposes upstream secrets

duration_ms: 1121.932446
type: 'test'
...
1..1

tests 1

suites 0

pass 1

fail 0

cancelled 0

skipped 0

todo 0

duration_ms 1307.963798

provisionarr@1.0.0 test
node --test test/*.test.js

TAP version 13

Subtest: plans fresh Sonarr and Radarr roots and managed qBittorrent clients

ok 1 - plans fresh Sonarr and Radarr roots and managed qBittorrent clients

duration_ms: 8.455417
type: 'test'
...

Subtest: is idempotent after the managed resources exist, including masked ARR passwords

ok 2 - is idempotent after the managed resources exist, including masked ARR passwords

duration_ms: 4.694959
type: 'test'
...

Subtest: updates only the Provisionarr-managed client and retains rollback data

ok 3 - updates only the Provisionarr-managed client and retains rollback data

duration_ms: 2.235917
type: 'test'
...

Subtest: normalizes trailing and repeated root slashes for exact root matching

ok 4 - normalizes trailing and repeated root slashes for exact root matching

duration_ms: 1.068959
type: 'test'
...

Subtest: rejects altered private requests and altered public changes

ok 5 - rejects altered private requests and altered public changes

duration_ms: 1.683209
type: 'test'
...

Subtest: rejects unsafe roots, URL credentials, query strings, fragments, and unsupported input

ok 6 - rejects unsafe roots, URL credentials, query strings, fragments, and unsupported input

duration_ms: 2.034667
type: 'test'
...

Subtest: public plans exclude credentials, private host values, and private rollback data

ok 7 - public plans exclude credentials, private host values, and private rollback data

duration_ms: 1.015584
type: 'test'
...

Subtest: reports managed root and client mismatches while accepting an ARR masked password

ok 8 - reports managed root and client mismatches while accepting an ARR masked password

duration_ms: 1.661042
type: 'test'
...

Subtest: Prowlarr compatibility returns redacted checks for a usable stack

ok 9 - Prowlarr compatibility returns redacted checks for a usable stack

duration_ms: 2.851042
type: 'test'
...

Subtest: Prowlarr compatibility identifies missing links and unhealthy status

ok 10 - Prowlarr compatibility identifies missing links and unhealthy status

duration_ms: 0.5705
type: 'test'
...

Subtest: Prowlarr treats an available empty health response as healthy

ok 11 - Prowlarr treats an available empty health response as healthy

duration_ms: 0.375084
type: 'test'
...

Subtest: qBittorrent compatibility exposes only queue counts and check summaries

ok 12 - qBittorrent compatibility exposes only queue counts and check summaries

duration_ms: 1.020542
type: 'test'
...

Subtest: qBittorrent compatibility rejects missing authentication, path, and queue access

ok 13 - qBittorrent compatibility rejects missing authentication, path, and queue access

duration_ms: 0.599959
type: 'test'
...

Subtest: qBittorrent groups unknown queue states without returning upstream text

ok 14 - qBittorrent groups unknown queue states without returning upstream text

duration_ms: 0.355833
type: 'test'
...

Subtest: preview normalizes simplified settings into fixed native requests

ok 15 - preview normalizes simplified settings into fixed native requests

duration_ms: 4.040458
type: 'test'
...

Subtest: diff is deterministic and omits unchanged settings

ok 16 - diff is deterministic and omits unchanged settings

duration_ms: 1.435291
type: 'test'
...

Subtest: repeating a plan is a no-op

ok 17 - repeating a plan is a no-op

duration_ms: 0.531416
type: 'test'
...

Subtest: rejects unknown services, groups, and settings

ok 18 - rejects unknown services, groups, and settings

duration_ms: 0.844667
type: 'test'
...

Subtest: rejects malformed values and sensitive fields instead of carrying them forward

ok 19 - rejects malformed values and sensitive fields instead of carrying them forward

duration_ms: 0.461125
type: 'test'
...

Subtest: application helper rejects forged or altered plans

ok 20 - application helper rejects forged or altered plans

duration_ms: 3.423583
type: 'test'
...

Subtest: returned plans and request bodies cannot mutate future results

ok 21 - returned plans and request bodies cannot mutate future results

duration_ms: 0.576917
type: 'test'
...

Subtest: ordinary users never receive owner access

ok 22 - ordinary users never receive owner access

duration_ms: 1096.189943
type: 'test'
...

Subtest: accepts only the exact fresh Prowlarr indexer and update conditions

ok 23 - accepts only the exact fresh Prowlarr indexer and update conditions

duration_ms: 1.993833
type: 'test'
...

Subtest: rejects unrelated, update-like, and fatal Prowlarr health conditions

ok 24 - rejects unrelated, update-like, and fatal Prowlarr health conditions

duration_ms: 0.490292
type: 'test'
...

Subtest: validates user-facing duration and GiB inputs and calculates ARR rates

ok 25 - validates user-facing duration and GiB inputs and calculates ARR rates

duration_ms: 2.935334
type: 'test'
...

Subtest: accepts duration aliases but rejects ambiguous or unsafe input

ok 26 - accepts duration aliases but rejects ambiguous or unsafe input

duration_ms: 1.58025
type: 'test'
...

Subtest: preview reports exact max-size changes without mutating quality definitions

ok 27 - preview reports exact max-size changes without mutating quality definitions

duration_ms: 1.647334
type: 'test'
...

Subtest: apply payload preserves min and preferred sizes unless explicitly overridden

ok 28 - apply payload preserves min and preferred sizes unless explicitly overridden

duration_ms: 0.705542
type: 'test'
...

Subtest: rejects an apply payload whose preserved or explicit values exceed the cap

ok 29 - rejects an apply payload whose preserved or explicit values exceed the cap

duration_ms: 2.995125
type: 'test'
...

Provisionarr owner setup token created at /tmp/provisionarr-query-mEoYew/setup-token.txt

Subtest: accepts real profile images and rejects disguised content

ok 30 - accepts real profile images and rejects disguised content

duration_ms: 3.954417
type: 'test'
...

Subtest: normalizes Southpark and extracts numeric and ordinal seasons

ok 31 - normalizes Southpark and extracts numeric and ordinal seasons

duration_ms: 4.995375
type: 'test'
...

Subtest: ranks an exact canonical Sonarr result above unrelated lookup results

ok 32 - ranks an exact canonical Sonarr result above unrelated lookup results

duration_ms: 2.067334
type: 'test'
...

Subtest: season monitoring preserves other existing seasons and enables the requested one

ok 33 - season monitoring preserves other existing seasons and enables the requested one

duration_ms: 0.481542
type: 'test'
...

Subtest: static paths remain inside the public directory

ok 34 - static paths remain inside the public directory

duration_ms: 0.753083
type: 'test'
...

Subtest: upstream transport accepts private HTTP services and rejects public plaintext targets

ok 35 - upstream transport accepts private HTTP services and rejects public plaintext targets

duration_ms: 9.231834
type: 'test'
...

Subtest: native installer scripts pass bash syntax validation

ok 36 - native installer scripts pass bash syntax validation

duration_ms: 20.727294
type: 'test'
...

Subtest: native installer help is non-mutating

ok 37 - native installer help is non-mutating

duration_ms: 37.163003
type: 'test'
...

Subtest: native service is loopback-only and unprivileged

ok 38 - native service is loopback-only and unprivileged

duration_ms: 1.702459
type: 'test'
...

Subtest: container image includes server modules

ok 39 - container image includes server modules

duration_ms: 1.044458
type: 'test'
...

Subtest: media stack deployment command documents dry run and rollback

ok 40 - media stack deployment command documents dry run and rollback

duration_ms: 168.445684
type: 'test'
...

Subtest: unauthenticated bootstrap is safe and ordinary users cannot administer

ok 41 - unauthenticated bootstrap is safe and ordinary users cannot administer

duration_ms: 423.741543
type: 'test'
...

Subtest: malformed cookies, oversized bodies, and stalled bodies fail without destabilizing the server

ok 42 - malformed cookies, oversized bodies, and stalled bodies fail without destabilizing the server

duration_ms: 5290.384989
type: 'test'
...

Subtest: notifications are authenticated, user-scoped, and readable with CSRF

ok 43 - notifications are authenticated, user-scoped, and readable with CSRF

duration_ms: 437.27146
type: 'test'
...

Subtest: audit records identify the actor and redact secret settings

ok 44 - audit records identify the actor and redact secret settings

duration_ms: 402.050623
type: 'test'
...

Subtest: session survives a process restart and remains bound to its user

ok 45 - session survives a process restart and remains bound to its user

duration_ms: 526.184844
type: 'test'
...

Subtest: rate limiting is isolated between authenticated sessions

ok 46 - rate limiting is isolated between authenticated sessions

duration_ms: 838.067334
type: 'test'
...

Subtest: owner maps an Emby profile and discovery uses that user watch history

ok 47 - owner maps an Emby profile and discovery uses that user watch history

duration_ms: 428.415501
type: 'test'
...

Subtest: ordinary account updates cannot change the owner-managed Emby profile mapping

ok 48 - ordinary account updates cannot change the owner-managed Emby profile mapping

duration_ms: 374.384787
type: 'test'
...

Subtest: proposal confirmation enforces ordinary-user approval policy before ARR mutation

ok 49 - proposal confirmation enforces ordinary-user approval policy before ARR mutation

duration_ms: 559.738432
type: 'test'
...

Subtest: concurrent requests cannot exceed an ordinary user active-request allotment

ok 50 - concurrent requests cannot exceed an ordinary user active-request allotment

duration_ms: 639.423356
type: 'test'
...

Subtest: orchestration inventory is owner-only and never exposes upstream secrets

ok 51 - orchestration inventory is owner-only and never exposes upstream secrets

duration_ms: 928.29401
type: 'test'
...

Subtest: connection URLs preserve a service base path without accepting embedded credentials

ok 52 - connection URLs preserve a service base path without accepting embedded credentials

duration_ms: 2.695875
type: 'test'
...

Subtest: connection hosts allow local media services but reject reserved metadata targets

ok 53 - connection hosts allow local media services but reject reserved metadata targets

duration_ms: 1.150626
type: 'test'
...

Subtest: connection API keys reject empty, control-character, and oversized values

ok 54 - connection API keys reject empty, control-character, and oversized values

duration_ms: 0.654208
type: 'test'
...

Subtest: qBittorrent credentials preserve passwords without accepting blank or control data

ok 55 - qBittorrent credentials preserve passwords without accepting blank or control data

duration_ms: 0.497292
type: 'test'
...

Subtest: normalizes dynamic schemas into safe UI metadata

ok 56 - normalizes dynamic schemas into safe UI metadata

duration_ms: 4.144876
type: 'test'
...

Subtest: identifies required editable fields without hardcoded indexer names

ok 57 - identifies required editable fields without hardcoded indexer names

duration_ms: 1.152375
type: 'test'
...

Subtest: validates a selection against the selected schema

ok 58 - validates a selection against the selected schema

duration_ms: 1.50325
type: 'test'
...

Subtest: rejects missing required, unknown, non-editable, and wrong-schema fields

ok 59 - rejects missing required, unknown, non-editable, and wrong-schema fields

duration_ms: 4.281959
type: 'test'
...

Subtest: builds the native POST payload while retaining schema descriptors

ok 60 - builds the native POST payload while retaining schema descriptors

duration_ms: 1.421
type: 'test'
...

Subtest: summaries expose configuration state but never field values

ok 61 - summaries expose configuration state but never field values

duration_ms: 1.246
type: 'test'
...

Subtest: normalization does not mutate the upstream schema

ok 62 - normalization does not mutate the upstream schema

duration_ms: 0.954334
type: 'test'
...

Subtest: creates native Sonarr and Radarr applications from Prowlarr schemas

ok 63 - creates native Sonarr and Radarr applications from Prowlarr schemas

duration_ms: 10.455085
type: 'test'
...

Subtest: updates existing applications while preserving native fields

ok 64 - updates existing applications while preserving native fields

duration_ms: 2.812833
type: 'test'
...

Subtest: returns an empty plan when both links already match

ok 65 - returns an empty plan when both links already match

duration_ms: 3.600042
type: 'test'
...

Subtest: verification accepts Prowlarr secret masking without relaxing URL checks

ok 66 - verification accepts Prowlarr secret masking without relaxing URL checks

duration_ms: 9.321376
type: 'test'
...

Subtest: rejects unknown choices and altered requests

ok 67 - rejects unknown choices and altered requests

duration_ms: 3.664792
type: 'test'
...

Subtest: public-data scan checks commits reachable from non-HEAD refs

ok 68 - public-data scan checks commits reachable from non-HEAD refs

duration_ms: 326.955741
type: 'test'
...

Subtest: stack generator returns a pinned four-service bundle without host control

ok 69 - stack generator returns a pinned four-service bundle without host control

duration_ms: 2.846667
type: 'test'
...

Subtest: stack generator validates the two installer modes

ok 70 - stack generator validates the two installer modes

duration_ms: 1.107459
type: 'test'
...

Subtest: managed output includes health checks, persistent mounts, and safe service addresses

ok 71 - managed output includes health checks, persistent mounts, and safe service addresses

duration_ms: 1.974
type: 'test'
...

Subtest: stack generator rejects broad system paths and unsupported fields

ok 72 - stack generator rejects broad system paths and unsupported fields

duration_ms: 0.648958
type: 'test'
...

Subtest: loader accepts only an unchanged generated bundle

ok 73 - loader accepts only an unchanged generated bundle

duration_ms: 10.526543
type: 'test'
...

Subtest: dry run validates Compose without creating directories

ok 74 - dry run validates Compose without creating directories

duration_ms: 7.097417
type: 'test'
...

Subtest: apply requires confirmation, creates approved directories, and waits for four services

ok 75 - apply requires confirmation, creates approved directories, and waits for four services

duration_ms: 5.815834
type: 'test'
...

Subtest: failed startup removes containers and preserves created directories

ok 76 - failed startup removes containers and preserves created directories

duration_ms: 4.477959
type: 'test'
...

Subtest: occupied service port stops apply before creating directories

ok 77 - occupied service port stops apply before creating directories

duration_ms: 5.467584
type: 'test'
...

Subtest: running-state timeout removes containers without deleting data

ok 78 - running-state timeout removes containers without deleting data

duration_ms: 4.861792
type: 'test'
...

Subtest: rollback requires confirmation and removes no data directories

ok 79 - rollback requires confirmation and removes no data directories

duration_ms: 2.748667
type: 'test'
...

Subtest: verification checks four running services, ports, and generated directories

ok 80 - verification checks four running services, ports, and generated directories

duration_ms: 3.630667
type: 'test'
...

Subtest: verification reports unavailable ports without changing the stack

ok 81 - verification reports unavailable ports without changing the stack

duration_ms: 4.540959
type: 'test'
...
1..81

tests 81

suites 0

pass 81

fail 0

cancelled 0

skipped 0

todo 0

duration_ms 10310.822786 (81/81)

provisionarr@1.0.0 check
node --check server.js && node --check public/app.js

provisionarr@1.0.0 public-safety
./scripts/public-safety-scan.sh

Public-data scan passed across 16 commit(s) and the working tree.
Public-safety scan passed.

No live services were contacted.

@ksudo-dev
ksudo-dev force-pushed the chore/postmerge-verify-provisionarr branch from f5336dd to f13dde5 Compare October 3, 2026 20:54
@ksudo-dev
ksudo-dev force-pushed the chore/postmerge-verify-provisionarr branch from f13dde5 to 91fc55b Compare October 3, 2026 20:57
@ksudo-dev
ksudo-dev marked this pull request as ready for review October 3, 2026 22:52
@ksudo-dev
ksudo-dev merged commit 64e40a8 into main Oct 3, 2026
7 checks passed
@ksudo-dev
ksudo-dev deleted the chore/postmerge-verify-provisionarr branch October 3, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant