Fix spawn! options-wrapping bug on tool-call rounds 2+#258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spawn!passedoptions: @optionswhich wrapped provider options one level deep on each recursive tool-call round. Round 2+ received{ options: { thinking: true } }instead of{ thinking: true }, silently dropping thinking config and any other provider-specific options.**@optionsso the hash is splatted back into keyword arguments correctly.Impact
All providers (Google, Anthropic, OpenAI) inherit
spawn!from the baseChatclass. Any provider-specific option passed via**options(e.g.thinking:,effort:) was lost on rounds 2+. This is the root cause of thinking deltas only appearing on round 1 in multi-round tool-calling sessions.Test plan
bundle exec rspecpasses (437 examples, 0 failures)bundle exec rubocoppasses (0 offenses)spawn!preserves options flat across rounds