OPS-REF-002A: split PostgreSQL source-family stable ID and SQL builders#650
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
src/carbonfactor_parser/persistence/postgresql_source_family_ids.pywhich exposessource_document_uuid(record),ingestion_run_uuid(record),master_uuid(source_family, master_id), anddetail_uuid(source_family, detail_id)and preserves the originaluuid.uuid5JSON tuple payload behavior.src/carbonfactor_parser/persistence/postgresql_source_family_sql.pywhich exposesmaster_insert_sql(source_family)anddetail_insert_sql(source_family)and preserves table names, column order, JSONB casts, conflict targets, andRETURNINGclauses.src/carbonfactor_parser/persistence/postgresql_source_family_repository.pyto call the new helpers (SQL builders and stable ID helpers) and to continue owning parameter mapping and execution logic.tests/test_postgresql_source_family_repository.pywith focused compatibility tests for stable UUID helpers, ingestion-run fallback determinism, and master/detail SQL shape and kept existing repository tests unchanged.Testing
python -m pytest tests/test_postgresql_source_family_repository.pywhich completed with15 passed, 1 skipped.python -m pytest tests/test_configured_cycle_runner.py tests/test_ingestion_run_history_mapping.py tests/test_ingestion_run_history_repository.py tests/test_ingestion_run_history_reader.pywhich completed with50 passed.python -m pytestwhich completed with2156 passed, 8 skipped.python -m ruff check src/carbonfactor_parser/persistence/postgresql_source_family_repository.py src/carbonfactor_parser/persistence/postgresql_source_family_ids.py src/carbonfactor_parser/persistence/postgresql_source_family_sql.py tests/test_postgresql_source_family_repository.pywhich passed, andgit diff --checkwhich reported no issues.Codex Task