OPS-REF-002D: split PostgreSQL execution helpers#653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
src/carbonfactor_parser/persistence/postgresql_execution.pywithexecute,fetchone,commit, androllbackthat retain the originalgetattr-based calling semantics and parameter handling.src/carbonfactor_parser/persistence/postgresql_source_family_repository.pyto import and use the new helpers in place of the internal_execute/_fetchone/_commit/_rollbackfunctions and removed those internal helpers.tests/test_postgresql_execution.pythat verifyexecutecalls with and without parameters,fetchonecalls, andcommit/rollbackbehavior when the methods are present or absent.Testing
python -m pytest tests/test_postgresql_source_family_repository.pywhich completed with21 passed, 1 skipped.python -m pytestwhich completed with2169 passed, 8 skipped.python -m ruff checkon the modified files and the checks passed.Codex Task