Conversation
…pository-contract [DN-043] [DN-043] .NET Parser run repository contract
…-parser-run-repository-contract [PT-043] [PT-043] Parity review for Parser run repository contract
…ily-master-detail-repository-contract [PY-044] [PY-044] Python Source-family master/detail repository contract
…-master-detail-repository-contract DN-044: .NET Source-family master/detail repository contract
…retry-and-recovery-visibility [OPS-030] [OPS-030] Add PR creation retry and recovery visibility
…-source-family-master-detail-repository-contrac [PT-044] [PT-044] Parity review for Source-family master/detail repository contract
…scovery-runtime-boundary [DN-045] [DN-045] .NET GHG source discovery runtime boundary
…label-state-transitions-in-workflows [OPS-031] [OPS-031] Fix task status label state transitions in workflows
…wnload-execution [DN-046] [DN-046] .NET GHG source download execution
…discovery-runtime-boundary [DN-047] [DN-047] .NET DEFRA source discovery runtime boundary
…-defra-source-discovery-runtime-boundary [PT-047] [PT-047] Parity review for DEFRA source discovery runtime boundary
…-download-execution-parity [OPS-032] [OPS-032] Align GHG source download execution parity
…-ghg-source-download-execution [PT-046] [PT-046] Parity review for GHG source download execution
…download-execution [DN-048] [DN-048] .NET DEFRA source download execution
…and-runtime-output OPS-LOG-001A add ingestion diagnostics boundaries
…-duplication-and-redaction Fix diagnostics issue de-duplication and expand redaction key coverage
…istory-schema Add parser ingestion run-history schema and PostgreSQL repository contract
…history-persistence Wire configured runner run history persistence
…istory-read-repository Add ingestion run history reader boundary
…rtifact-transport Split configured cycle config loading and artifact transport
…tion-module Split configured cycle dependency composition
…history-helpers Split configured cycle summary and history helpers
…builders OPS-REF-002A: split PostgreSQL source-family stable ID and SQL builders
…and-json-helpers OPS-REF-002B: Split PostgreSQL source-family parameter mapping
…d-ingestion-run-upsert-helpers Split source-family ingestion-run and source-document upserts into helpers
…on-helpers OPS-REF-002D: split PostgreSQL execution helpers
…cumentation OPS-POLISH-001: Polish public repository status docs
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5bb6ab9bd9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def is_success(self) -> bool: | ||
| """Return whether the insert summary has no failed rows.""" | ||
|
|
||
| return self.failed == 0 and not self.status.startswith("failed") |
There was a problem hiding this comment.
When a parser returns a valid but empty batch, PostgreSQLSourceFamilyRuntimeRepository reports status='no_records', attempted=0, and failed=0; this predicate treats that as success, so _run_source_family advances record_ingested_year and future cycles skip that year even though no factor rows were persisted. Please require actual attempted rows/records, or treat no_records as a failed/no-op insert, before marking the source year completed.
Useful? React with 👍 / 👎.
| status = ( | ||
| ParsedFactorPersistenceStatus.DECLARED | ||
| if repository_result.status is SourceFamilyRepositoryPersistStatus.DECLARED | ||
| else ParsedFactorPersistenceStatus.FAILED_VALIDATION |
There was a problem hiding this comment.
When repository.persist_source_family_records returns SourceFamilyRepositoryPersistStatus.FAILED_DATABASE (for example after a PostgreSQL insert error), this collapses every non-DECLARED result into FAILED_VALIDATION. Direct callers of persist_parsed_factor_records then see final_status='failed_validation' for an infrastructure/database failure and cannot distinguish it from bad input data, so retry/error handling will be misleading; preserve or expose the database-failure status here.
Useful? React with 👍 / 👎.
2 participants
Summary
Briefly describe the task and outcome.
Changes
Validation
git diff --checkpassedScope Guard Checklist
Deferred Items
Reviewer Notes