Skip to content

Retain order of domains#76

Closed
zx2c4 wants to merge 1 commit intokuba:masterfrom
zx2c4:domain-order-cn
Closed

Retain order of domains#76
zx2c4 wants to merge 1 commit intokuba:masterfrom
zx2c4:domain-order-cn

Conversation

@zx2c4
Copy link

@zx2c4 zx2c4 commented Feb 24, 2016

This ensures that the first domain specified on the command line will be
the domain that winds up in the CN field. Otherwise, users have no way
of controlling this.

Fixes: #72
Signed-off-by: Jason A. Donenfeld Jason@zx2c4.com

This ensures that the first domain specified on the command line will be
the domain that winds up in the CN field. Otherwise, users have no way
of controlling this.

Fixes: #72
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
@kuba
Copy link
Owner

kuba commented Feb 27, 2016

Unfortunately, collectsions.OrderedDict is not available in all supported Python versions (here py 2.6). Since you haven't fixed the build error for a while I'm going to close this PR. BTW, I feel that any kind of other implementation of #72, in the light of #72 (comment), would be quite complicated, defeating the purpose of being a "simple" client.

@kuba kuba closed this Feb 27, 2016
@zx2c4
Copy link
Author

zx2c4 commented Feb 28, 2016

Fixed in #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants