Skip to content

fix git signing for automatic meeting notes sync via github action#234

Merged
kubeedge-bot merged 5 commits intokubeedge:masterfrom
kevin-wangzefeng:auto-sync-meeting-notes
Oct 30, 2025
Merged

fix git signing for automatic meeting notes sync via github action#234
kubeedge-bot merged 5 commits intokubeedge:masterfrom
kevin-wangzefeng:auto-sync-meeting-notes

Conversation

@kevin-wangzefeng
Copy link
Member

@kevin-wangzefeng kevin-wangzefeng commented Oct 29, 2025

fixes: #233

  1. Fix the git signing with wrong user issue:

Summary
Commit sha: e9d0e81, Author: kubeedge-bot, Committer: github-actions[bot]; Expected "kubeedge-bot 48982446+kubeedge-bot@users.noreply.github.com", but got "github-actions[bot] <github-actions[bot]@users.noreply.github.com>".

  1. removed writting service_accout to disk, to avoid potential risk.

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 29, 2025
Signed-off-by: Kevin Wang <kevinwzf0126@gmail.com>
Signed-off-by: Kevin Wang <kevinwzf0126@gmail.com>
@kubeedge-bot kubeedge-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 30, 2025
Signed-off-by: Kevin Wang <kevinwzf0126@gmail.com>
…ithub-actions[bot]

Signed-off-by: Kevin Wang <kevinwzf0126@gmail.com>
@kevin-wangzefeng
Copy link
Member Author

There's a live preview at my personal fork repo: kevin-wangzefeng#6

The author and committer is set to github.actor, meanly: either who triggered the action or github-actions[bot]

Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2025
Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

…ion vars

Signed-off-by: Kevin Wang <kevinwzf0126@gmail.com>
@kubeedge-bot kubeedge-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2025
Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2025
@Shelley-BaoYue Shelley-BaoYue added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2025
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Shelley-BaoYue

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot merged commit 90f240e into kubeedge:master Oct 30, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants