Skip to content

update whitelist for codespell, skip codespell check for meeting-notes#242

Merged
kubeedge-bot merged 1 commit intokubeedge:masterfrom
Shelley-BaoYue:add-codespell-whitelist
Dec 12, 2025
Merged

update whitelist for codespell, skip codespell check for meeting-notes#242
kubeedge-bot merged 1 commit intokubeedge:masterfrom
Shelley-BaoYue:add-codespell-whitelist

Conversation

@Shelley-BaoYue
Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue commented Nov 24, 2025

  • Update whitelist for codespell
  • Skip codespell check for auto-sync meeting-notes

@kubeedge-bot kubeedge-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Shelley-BaoYue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the project's overall quality by refining automated spell checking and correcting a minor documentation error. It updates the codespell whitelist to include specific terms, preventing unnecessary flags, and rectifies a typo in a candidate's profile to maintain professional accuracy.

Highlights

  • Codespell Whitelist Update: Added "COO" and "AndroidOS" to the codespell_whitelist.txt file to prevent false positives during automated spell checking.
  • Typo Correction: Corrected a spelling error from "deveoper" to "developer" in the candidate-HongbingZhang.md file, ensuring accuracy in the candidate's profile.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/codespell.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 24, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the codespell whitelist and fixes a typo in a candidate's markdown file. The changes are functional and improve the codebase. I have one suggestion regarding the whitelist file to improve its long-term maintainability. Please also note the [wip] prefix in the PR title, which should be removed when this is ready for merging. Given that one of the modified files is a public-facing document, a thorough proofread for any other potential typos or inaccuracies would be beneficial.

Comment on lines +5 to +6
COO
AndroidOS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability, it's a good practice to keep whitelist files like this sorted alphabetically. As this list grows, a sorted file makes it easier to check for existing entries and prevent duplicates.

@Shelley-BaoYue Shelley-BaoYue force-pushed the add-codespell-whitelist branch 6 times, most recently from 2f7f0ca to aae21b1 Compare November 24, 2025 08:51
Signed-off-by: Shelley-BaoYue <baoyue2@huawei.com>
@Shelley-BaoYue Shelley-BaoYue force-pushed the add-codespell-whitelist branch from aae21b1 to 1181fdf Compare November 24, 2025 08:52
@Shelley-BaoYue Shelley-BaoYue changed the title [wip]update whitelist for codespell update whitelist for codespell, skip codespell check for meeting-notes Nov 24, 2025
@kubeedge-bot kubeedge-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2025
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI.

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2025
Copy link
Member

@kevin-wangzefeng kevin-wangzefeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fujitatomoya, kevin-wangzefeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2025
@kubeedge-bot kubeedge-bot merged commit 63b15f5 into kubeedge:master Dec 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants