Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the official blog post for the KubeEdge v1.23.0 release, alongside its Chinese localization, and updates the system's latest version indicator. The release itself brings substantial improvements, focusing on enhancing Windows compatibility for EdgeCore and Keadm, integrating a device anomaly detection framework, optimizing edge-to-cloud bandwidth usage for node querying, and refactoring the edge database for better performance and maintainability. Additionally, it includes an upgrade to Kubernetes v1.32.10 and a new Dashboard version with internationalization and UI enhancements. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
kubeedge-bot
added
the
size/L
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the release blog for KubeEdge v1.23.0 and updates the project's latest version. While the changes are straightforward, I've identified several issues in the new blog post files (.mdx), including broken internal links, typos, and incorrect/missing references. These issues affect both the English and Chinese versions of the post. Addressing these will improve the clarity and professionalism of the release announcement. The update to functions/latestversion.js is correct.
blog/release-v1.23/index.mdx
Outdated
| - [EdgeCore and Keadm Capability Enhancements on Windows OS](#add-holdrelease-mechanism-for-controlling-edge-resource-updates) | ||
| - [Support Device Anomaly Detection in Device CRDs and mappers](#beehive-framework-upgrade-supporting-configurable-submodule-restart-policies) | ||
| - [Optimizing Node Querying Path from Edge to Reduce Edge-Cloud Bandwidth](#device-model-update-based-on-thing-model-and-product-concept) | ||
| - [Replace Beego with Gorm and Reconstruct Edge DB](#add-featuregates-for-pod-resources-server-and-csi-plugin-in-edgecore-integrated-lightweight-kubelet) | ||
| - [Upgrade Kubernetes Dependency to v1.32.10](#upgrade-kubernetes-dependency-to-v13210) | ||
| - [New Release Dashboard: i18n(Chinese), Performance Enhancements and UI Improvement](#c-language-mapper-framework-support) |
There was a problem hiding this comment.
The anchor links in the "What's New" section are incorrect. They appear to be copied from a previous release and do not point to the correct sections in this document. Please update them to match the section headers.
- [EdgeCore and Keadm Capability Enhancements on Windows OS](#edgecore-and-keadm-capability-enhancements-on-windows-os)
- [Support Device Anomaly Detection in Device CRDs and mappers](#support-device-anomaly-detection-in-device-crds-and-mappers)
- [Optimizing Node Querying Path from Edge to Reduce Edge-Cloud Bandwidth](#optimizing-node-querying-path-from-edge-to-reduce-edge-cloud-bandwidth)
- [Replace Beego with Gorm and Reconstruct Edge DB](#replace-beego-with-gorm-and-reconstruct-edge-db)
- [Upgrade Kubernetes Dependency to v1.32.10](#upgrade-kubernetes-dependency-to-v13210)
- [New Release Dashboard: i18n(Chinese), Performance Enhancements and UI Improvement](#new-release-dashboard-i18nchinese-performance-enhancements-and-ui-improvement)
|
|
||
| **Refer to the link for more details.([#6580](https://github.com/kubeedge/kubeedge/pull/6580))** | ||
|
|
||
| - Observability Enhancement: In new release, when EdgeCore runs as a Windows service, logs are redirected to a log file. This improves troubleshooting and operational visibility on Windows. |
There was a problem hiding this comment.
Minor grammatical correction: "In new release" should be "In the new release".
- Observability Enhancement: In the new release, when EdgeCore runs as a Windows service, logs are redirected to a log file. This improves troubleshooting and operational visibility on Windows.
|
|
||
| ### Upgrade Kubernetes Dependency to v1.32.10 | ||
|
|
||
| Upgrade the vendered kubernetes version to v1.32.10, users are now able to use the features of new version on the cloud and on the edge side. |
There was a problem hiding this comment.
There's a typo in "vendered"; it should be "vendored". Also, "Kubernetes" is a proper noun and should be capitalized for consistency.
Upgrade the vendored Kubernetes version to v1.32.10, users are now able to use the features of new version on the cloud and on the edge side.
blog/release-v1.23/index.mdx
Outdated
|
|
||
| ## Important Steps before Upgrading | ||
|
|
||
| - In v1.23.0, we extract the status part of `Device CRD` into a seperate `DeviceStatus CRD`. This change maintains backward compatibility with older versions of the CRD. However, please note that device status must now be retrieved from the new `DeviceStatus CRD`. You can refer to [#6534](https://github.com/kubeedge/kubeedge/pull/6534) for more details. No newline at end of file |
There was a problem hiding this comment.
There's a typo in "seperate". It should be "separate".
- In v1.23.0, we extract the status part of `Device CRD` into a separate `DeviceStatus CRD`. This change maintains backward compatibility with older versions of the CRD. However, please note that device status must now be retrieved from the new `DeviceStatus CRD`. You can refer to [#6534](https://github.com/kubeedge/kubeedge/pull/6534) for more details.
| - [Windows 操作系统下的 EdgeCore 与 Keadm 能力增强](#新增-holdrelease-机制控制边缘资源更新) | ||
| - [新增设备异常检测能力](#beehive框架升级支持配置子模块重启策略) | ||
| - [优化边缘侧查询节点流程，降低边云通道带宽占用](#基于物模型与产品概念的设备模型能力升级) | ||
| - [使用 Gorm 替换 Beego，并重构边缘数据库](#边缘轻量化kubelet新增-pod-resources-server-和-csi-plugin-特性开关) | ||
| - [升级 K8s 依赖到1.32](#c语言版本mapper-framework支持) | ||
| - [Dashboard 新版本发布：国际化（中文）支持、性能提升与页面优化](#升级k8s依赖到131) |
There was a problem hiding this comment.
The anchor links in the "新增特性" (What's New) section are incorrect and do not point to the corresponding sections. They seem to be copied from the v1.22 release notes.
- [Windows 操作系统下的 EdgeCore 与 Keadm 能力增强](#windows-操作系统下的-edgecore-与-keadm-能力增强)
- [新增设备异常检测能力](#新增设备异常检测能力)
- [优化边缘侧查询节点流程，降低边云通道带宽占用](#优化边缘侧查询节点流程降低边云通道带宽占用)
- [使用 Gorm 替换 Beego，并重构边缘数据库](#使用-gorm-替换-beego并重构边缘数据库)
- [升级 K8s 依赖到1.32](#升级-k8s-依赖到132)
- [Dashboard 新版本发布：国际化（中文）支持、性能提升与页面优化](#dashboard-新版本发布国际化中文支持性能提升与页面优化)
| 在1.23.0版本中，我们对 EdgeCore 和 keadm 在 Windows OS 的能力进行了如下增强： | ||
|
|
||
| - 提供了本地DMI服务：由于 Windows 不支持 Unix Domain Socket，我们引用了Windows 命名管道（Named Pipes）实现本地网络通信。 | ||
| - keadm 升级/下载增强：在v1.23.0中，keadm 会检测本地`edgecore.exe`的版本信息，如果或有更高版本可用，则自动重新下载 EdgeCore 包，避免因本地已存在`edgecore.exe`而导致升级被跳过 |
There was a problem hiding this comment.
There appears to be a typo. "如果或有更高版本可用" should likely be "如果有更高版本可用" (If a newer version is available).
- keadm 升级/下载增强：在v1.23.0中，keadm 会检测本地`edgecore.exe`的版本信息，如果有更高版本可用，则自动重新下载 EdgeCore 包，避免因本地已存在`edgecore.exe`而导致升级被跳过
|
|
||
| ### 新增设备异常检测能力 | ||
|
|
||
| v1.23.0 引入了设备异常检测框架，您可在 Device CRD 的 pushMethod 字段中指定异常检测相关配置： |
There was a problem hiding this comment.
There is an extra space between "的" and "pushMethod", which should be removed.
v1.23.0 引入了设备异常检测框架，您可在 Device CRD 的 pushMethod 字段中指定异常检测相关配置：
| spec: | ||
| properties: | ||
| pushMethod: | ||
| anomolyDetection: |
There was a problem hiding this comment.
There is a typo in anomolyDetection. It should be anomalyDetection.
anomalyDetection:
|
|
||
| **更多信息可参考：** | ||
|
|
||
| https://github.com/kubeedge/kubeedge/pull/6543 |
There was a problem hiding this comment.
This pull request link appears to be incorrect for this section. The English version of the blog post links to PR #6489 for this topic (optimizing node querying). PR #6543, which is currently linked, is for device anomaly detection.
https://github.com/kubeedge/kubeedge/pull/6489
|
|
||
| ## 版本升级注意事项 | ||
|
|
||
| v1.23.0 开始，Device CRD 的 `Status` 字段将分离出来，单独作为 `DeviceStatus CRD` 使用。该变更兼容旧版CRD，但需注意，在后续版本中设备状态需要通过新的 `DeviceStatus CRD` 获取。 |
There was a problem hiding this comment.
This section is missing the reference to pull request #6534, which is present in the English version of the blog post. Adding it would provide more context for readers.
v1.23.0 开始，Device CRD 的 `Status` 字段将分离出来，单独作为 `DeviceStatus CRD` 使用。该变更兼容旧版CRD，但需注意，在后续版本中设备状态需要通过新的 `DeviceStatus CRD` 获取。详情请参考 [#6534](https://github.com/kubeedge/kubeedge/pull/6534)。
Signed-off-by: Shelley-BaoYue <baoyue2@huawei.com>
Shelley-BaoYue
force-pushed
the
release-v1.23-blog
branch
from
bf911a5 to
96bb8e8
Compare
2 participants
Which issue(s) this PR fixes:
kubeedge/kubeedge#6657
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Add 1.23.0 release blog
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: