Conversation
Signed-off-by: Shelley-BaoYue <baoyue2@huawei.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the documentation versioning configuration by integrating the new 1.23 release into the version bar. This ensures users can access the latest documentation while also maintaining a curated list of older versions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly updates the documentation version list to include v1.23. However, this change introduces an inconsistency with another part of the codebase that defines the latest version. I've left a comment with a suggestion to address this to ensure consistency across the project.
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "Next": "/docs/", | |||
| "v1.23": "https://release-1-23.docs.kubeedge.io/docs/", | |||
There was a problem hiding this comment.
Adding v1.23 here updates the documentation version selector, which is correct. However, this makes the latestVersion constant in functions/latestversion.js outdated, as it's still set to v1.22.0. To ensure consistency across the website and that users are aware of the latest version, please also update the latestVersion constant in functions/latestversion.js to reflect the new latest version.
Which issue(s) this PR fixes:
kubeedge/kubeedge#6657
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Add docs version bar for 1.23, and this PR need to be cherry-picked to release 1.20-1.22
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: