refactor: update PolicyObservedClusterCount in one place in collectScheduledClusters#692
Draft
Copilot wants to merge 3 commits into
Draft
refactor: update PolicyObservedClusterCount in one place in collectScheduledClusters#692Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Copilot started work on behalf of
Britania Rodriguez Reyes (britaniar)
May 5, 2026 17:56
View session
…heduledClusters Agent-Logs-Url: https://github.com/kubefleet-dev/kubefleet/sessions/8cb9e894-f2d2-498f-970a-4242477b9f20 Co-authored-by: britaniar <145056127+britaniar@users.noreply.github.com>
… in collectScheduledClusters Agent-Logs-Url: https://github.com/kubefleet-dev/kubefleet/sessions/8cb9e894-f2d2-498f-970a-4242477b9f20 Co-authored-by: britaniar <145056127+britaniar@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor to update PolicyObservedClusterCount in one place
refactor: update PolicyObservedClusterCount in one place in collectScheduledClusters
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PolicyObservedClusterCountwas written in two places:determinePolicySnapshotset it to-1as a sentinel for PickAll policy, thencollectScheduledClustersdetected that sentinel and overwrote it withlen(selectedBindings).Changes
determinePolicySnapshot: Remove thePolicyObservedClusterCountassignment entirely; update the klog to reference the localclusterCountvariable directly.collectScheduledClusters: AddclusterCount intparameter. Validate count mismatch first, then setPolicyObservedClusterCount = len(selectedBindings)unconditionally in one place — valid for both PickAll (clusterCount == -1) and other policies (where the preceding check guaranteesclusterCount == len(selectedBindings)).initializenow captures and forwardsclusterCount;validateforwards its existingclusterCount.